address CR feedback

Author: kg-aws

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.ts

@@ -131,7 +131,7 @@ const target = service.loadBalancerTarget({
   containerName: 'nginx',
   containerPort: 80,
   protocol: ecs.Protocol.TCP,
-}, new ecs.AlternateTarget({
+}, new ecs.AlternateTarget('LBAlternateOptions', {
   alternateTargetGroup: greenTargetGroup,
   productionListener: ecs.ListenerRuleConfiguration.applicationListenerRule(prodListenerRule),
 }));

packages/aws-cdk-lib/aws-ecs/lib/alternate-target-configuration.ts

@@ -108,12 +108,6 @@ export interface AlternateTargetOptions {
  * Properties for AlternateTarget configuration
  */
 export interface AlternateTargetProps extends AlternateTargetOptions {
-  /**
-   * Id for alternate target options
-   * @default - none
-   */
-  readonly id?: string;
-
   /**
    * The alternate target group
    */
@@ -129,7 +123,7 @@ export interface AlternateTargetProps extends AlternateTargetOptions {
  * Configuration for alternate target groups used in blue/green deployments with load balancers
  */
 export class AlternateTarget implements IAlternateTarget {
-  constructor(private readonly props: AlternateTargetProps) {}
+  constructor(private readonly id: string, private readonly props: AlternateTargetProps) { }
 
   /**
    * Bind this configuration to a service
@@ -144,7 +138,7 @@ export class AlternateTarget implements IAlternateTarget {
       resources.push(this.props.testListener._listenerArn);
     }
 
-    const roleId = this.props.id? `${this.props.id}Role`: 'LBAlternateOptionsRole';
+    const roleId = `${this.id}Role`;
     const role = this.props.role ?? new iam.Role(scope, roleId, {
       assumedBy: new iam.ServicePrincipal('ecs.amazonaws.com'),
       managedPolicies: [

packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts

@@ -1285,14 +1285,13 @@ export abstract class BaseService extends Resource
     const self = this;
     const target = this.taskDefinition._validateTarget(options);
     const connections = self.connections;
-    const alternateOption = alternateOptions;
     return {
       attachToApplicationTargetGroup(targetGroup: elbv2.ApplicationTargetGroup): elbv2.LoadBalancerTargetProps {
         targetGroup.registerConnectable(self, self.taskDefinition._portRangeFromPortMapping(target.portMapping));
-        return self.attachToELBv2(targetGroup, target.containerName, target.portMapping.containerPort!, alternateOption);
+        return self.attachToELBv2(targetGroup, target.containerName, target.portMapping.containerPort!, alternateOptions);
       },
       attachToNetworkTargetGroup(targetGroup: elbv2.NetworkTargetGroup): elbv2.LoadBalancerTargetProps {
-        return self.attachToELBv2(targetGroup, target.containerName, target.portMapping.containerPort!, alternateOption);
+        return self.attachToELBv2(targetGroup, target.containerName, target.portMapping.containerPort!, alternateOptions);
       },
       connections,
       attachToClassicLB(loadBalancer: elb.LoadBalancer): void {

packages/aws-cdk-lib/aws-ecs/test/alternate-target-configuration.test.ts

@@ -69,7 +69,7 @@ describe('AlternateTarget', () => {
     });
 
     // WHEN
-    const alternateTarget = new ecs.AlternateTarget({
+    const alternateTarget = new ecs.AlternateTarget('GreenTG', {
       alternateTargetGroup: greenTargetGroup,
       productionListener: ecs.ListenerRuleConfiguration.applicationListenerRule(prodRule),
     });
@@ -111,7 +111,7 @@ describe('AlternateTarget', () => {
     });
 
     // WHEN
-    const alternateTarget = new ecs.AlternateTarget({
+    const alternateTarget = new ecs.AlternateTarget('GreenTG', {
       alternateTargetGroup: greenTargetGroup,
       productionListener: ecs.ListenerRuleConfiguration.applicationListenerRule(prodRule),
       testListener: ecs.ListenerRuleConfiguration.applicationListenerRule(testRule),
@@ -163,7 +163,7 @@ describe('AlternateTarget', () => {
     });
 
     // WHEN
-    const alternateTarget = new ecs.AlternateTarget({
+    const alternateTarget = new ecs.AlternateTarget('GreenTG', {
       alternateTargetGroup: greenTargetGroup,
       productionListener: ecs.ListenerRuleConfiguration.applicationListenerRule(prodRule),
       role: customRole,
@@ -230,7 +230,7 @@ describe('AlternateTarget', () => {
     });
 
     // WHEN
-    const alternateTarget = new ecs.AlternateTarget({
+    const alternateTarget = new ecs.AlternateTarget('GreenTG', {
       alternateTargetGroup: nlbGreenTargetGroup,
       productionListener: ecs.ListenerRuleConfiguration.networkListener(nlbListener),
     });