You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(s3-deployment): broken cross stack reference when using Source.data (#34916)
### Issue #22843Closes#22843.
### Reason for this change
The s3-deployment construct implementation had its own implmenetation of resolving references. This is unnecessary as these references should be resolved in the synthesis stage. Furthermore, this implementation did not support cross-stack references.
### Description of changes
The construct will now pass the tokens as is and let the app synthesis take care of resolving the references instead as expected. Non-tokens will not use markers.
Note: Credits to @smnrd who has written the reproduction steps here: #22843
This has helped in writing the nested stack integration test.
### Describe any new or updated permissions being added
No new permissions are added.
### Description of how you validated changes
Unit tests, Integrations tests, and manually via the AWS console.
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy file name to clipboardExpand all lines: packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment-cross-nested-stack-source.js.snapshot/MainStack.assets.json
0 commit comments