From 06e094e66e0cdc0ac9c772f3b63b007d1a319ade Mon Sep 17 00:00:00 2001 From: abdennour Date: Fri, 7 Jul 2017 05:19:06 +0300 Subject: [PATCH 1/2] Use of "var" is deprecated. Instead , use "const" or "let" according to the situation. Use Arrow function coming with ES6 . More elegance to the code . --- sample.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/sample.js b/sample.js index 5d947ff..3bb8c5a 100644 --- a/sample.js +++ b/sample.js @@ -1,12 +1,12 @@ /* * Copyright 2013. Amazon Web Services, Inc. All Rights Reserved. - * + * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -15,22 +15,22 @@ **/ // Load the SDK and UUID -var AWS = require('aws-sdk'); -var uuid = require('node-uuid'); +const AWS = require('aws-sdk'); +const uuid = require('node-uuid'); // Create an S3 client -var s3 = new AWS.S3(); +const s3 = new AWS.S3(); // Create a bucket and upload something into it -var bucketName = 'node-sdk-sample-' + uuid.v4(); -var keyName = 'hello_world.txt'; +const bucketName = `node-sdk-sample-${uuid.v4()}`; +const keyName = 'hello_world.txt'; -s3.createBucket({Bucket: bucketName}, function() { - var params = {Bucket: bucketName, Key: keyName, Body: 'Hello World!'}; - s3.putObject(params, function(err, data) { +s3.createBucket({Bucket: bucketName}, () => { + const params = {Bucket: bucketName, Key: keyName, Body: 'Hello World!'}; + s3.putObject(params, (err, data) => { if (err) console.log(err) else - console.log("Successfully uploaded data to " + bucketName + "/" + keyName); + console.log("Successfully uploaded data to " , bucketName , "/" , keyName); }); }); From 2a9ace7aca07f8ddc8afb2f1ee251be0054a0442 Mon Sep 17 00:00:00 2001 From: abdennour Date: Fri, 7 Jul 2017 05:22:00 +0300 Subject: [PATCH 2/2] Consistency of quotes use . Do not use sometimes double quotes and sometimes simple quotes --- sample.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample.js b/sample.js index 3bb8c5a..55288b9 100644 --- a/sample.js +++ b/sample.js @@ -31,6 +31,6 @@ s3.createBucket({Bucket: bucketName}, () => { if (err) console.log(err) else - console.log("Successfully uploaded data to " , bucketName , "/" , keyName); + console.log('Successfully uploaded data to ' , bucketName , '/' , keyName); }); });