Enable AdoptedResource and add required custom logic for ScalableTarget

Author: mbaijal

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,14 +1,14 @@
 ack_generate_info:
-  build_date: "2021-09-08T23:45:08Z"
+  build_date: "2021-09-10T17:51:36Z"
   build_hash: 394e8294aabf0b221c35f7a5c7bc7e4e43bc6f10
-  go_version: go1.16.4 linux/amd64
+  go_version: go1.14.14 darwin/amd64
   version: v0.13.2
 api_directory_checksum: 155104e002d9c69b75fd9e85789bf7ee292b866c
 api_version: v1alpha1
 aws_sdk_go_version: v1.37.10
 generator_config_info:
-  file_checksum: 4bf1e52543400e3d52cc745da4c1e2e518e9e1e1
+  file_checksum: ef8cd242243fc5a9d7b2f0e8f689798458b85d43
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
-  timestamp: 2021-09-08 23:45:13.439536495 +0000 UTC
+  timestamp: 2021-09-10 17:51:47.055507 +0000 UTC

apis/v1alpha1/generator.yaml

@@ -15,16 +15,18 @@ operations:
     resource_name: ScalableTarget
   DescribeScalableTargets:
     primary_identifier_field_name: ResourceId
+    custom_check_required_fields_missing_method: customCheckRequiredFieldsMissingMethod
   DescribeScalingPolicies:
     primary_identifier_field_name: ResourceId
 resources:
   ScalableTarget:
-    is_adoptable: false
     hooks:
         sdk_read_many_post_build_request:
           code: rm.customDescribeScalableTarget(ctx, r, input)
         delta_pre_compare:
           code: customSetDefaults(a, b)
+        set_identifiers_pre_read_one:
+          code: r.customSetIdentifierCode(identifier)
     fields:
       ResourceID:
         is_name: true
@@ -33,8 +35,12 @@ resources:
         from:
           operation: DescribeScalableTargets
           path: ScalableTargets..CreationTime
+      # ResourceIds:
+      #   is_read_only: true
+      #   from:
+      #     operation: DescribeScalableTargets
+      #     path: ScalableTargets..ResourceId
   ScalingPolicy:
-    is_adoptable: false
     fields:
       ResourceID:
         is_name: true

generator.yaml

@@ -15,16 +15,18 @@ operations:
     resource_name: ScalableTarget
   DescribeScalableTargets:
     primary_identifier_field_name: ResourceId
+    custom_check_required_fields_missing_method: customCheckRequiredFieldsMissingMethod
   DescribeScalingPolicies:
     primary_identifier_field_name: ResourceId
 resources:
   ScalableTarget:
-    is_adoptable: false
     hooks:
         sdk_read_many_post_build_request:
           code: rm.customDescribeScalableTarget(ctx, r, input)
         delta_pre_compare:
           code: customSetDefaults(a, b)
+        set_identifiers_pre_read_one:
+          code: r.customSetIdentifierCode(identifier)
     fields:
       ResourceID:
         is_name: true
@@ -34,7 +36,6 @@ resources:
           operation: DescribeScalableTargets
           path: ScalableTargets..CreationTime
   ScalingPolicy:
-    is_adoptable: false
     fields:
       ResourceID:
         is_name: true

pkg/resource/scalable_target/custom_api.go

@@ -15,6 +15,7 @@ package scalable_target
 
 import (
 	"context"
+	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
 	svcsdk "github.com/aws/aws-sdk-go/service/applicationautoscaling"
 )
 
@@ -31,3 +32,19 @@ func (rm *resourceManager) customDescribeScalableTarget(
 		input.SetResourceIds(resourceIDList)
 	}
 }
+
+func (r *resource) customSetIdentifierCode(
+	identifier *ackv1alpha1.AWSIdentifiers,
+) {
+	r.ko.Spec.ResourceID = &identifier.NameOrID
+}
+
+// customCheckRequiredFieldsMissingMethod returns true if there are any fields
+// for the ReadOne Input shape that are required but not present in the
+// resource's Spec or Status
+func (rm *resourceManager) customCheckRequiredFieldsMissingMethod(
+	r *resource,
+) bool {
+	return r.ko.Spec.ResourceID == nil
+
+}

pkg/resource/scalable_target/manager_factory.go

@@ -20,6 +20,7 @@
 
 SERVICE_NAME = "applicationautoscaling"
 CRD_GROUP = "applicationautoscaling.services.k8s.aws"
+ADOPTED_RESOURCE_CRD_GROUP = "services.k8s.aws"
 CRD_VERSION = "v1alpha1"
 
 # PyTest marker for the current service
@@ -61,3 +62,21 @@ def create_applicationautoscaling_resource(
     )
 
     return reference, spec, resource
+
+def create_adopted_resource(resource_name, spec_file, replacements, namespace="default"):
+    """
+    Wrapper around k8s.load_and_create_resource to create a Adopoted resource
+    """
+
+    reference, spec, resource = k8s.load_and_create_resource(
+        resource_directory,
+        ADOPTED_RESOURCE_CRD_GROUP,
+        CRD_VERSION,
+        "adoptedresources",
+        resource_name,
+        spec_file,
+        replacements,
+        namespace,
+    )
+
+    return reference, spec, resource

pkg/resource/scalable_target/resource.go

@@ -0,0 +1,71 @@
+# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may
+# not use this file except in compliance with the License. A copy of the
+# License is located at
+#
+# 	 http://aws.amazon.com/apache2.0/
+#
+# or in the "license" file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.
+
+
+import boto3
+
+def application_autoscaling_client():
+    return boto3.client("application-autoscaling")
+
+def sagemaker_endpoint_register_scalable_target(resource_id):
+    target_input = {
+        "ServiceNamespace": "sagemaker",
+        "ResourceId": resource_id,
+        "ScalableDimension": "sagemaker:variant:DesiredInstanceCount", 
+        "MinCapacity": 1,
+        "MaxCapacity": 2,
+    }
+
+    target_response = application_autoscaling_client().register_scalable_target(**target_input)
+    return target_response
+
+def sagemaker_endpoint_put_scaling_policy(resource_id, policy_name):
+    policy_input = {
+        "PolicyName": policy_name,
+        "ServiceNamespace": "sagemaker",
+        "ResourceId": resource_id,
+        "ScalableDimension": "sagemaker:variant:DesiredInstanceCount", 
+        "PolicyType": "TargetTrackingScaling",
+        "TargetTrackingScalingPolicyConfiguration": {
+            "TargetValue": 70.0,
+            "ScaleInCooldown": 700,
+            "ScaleOutCooldown": 300,
+            "PredefinedMetricSpecification": {
+                "PredefinedMetricType": "SageMakerVariantInvocationsPerInstance",
+            },
+        }
+    }
+
+    policy_response = application_autoscaling_client().put_scaling_policy(**policy_input)
+    return policy_response
+
+def sagemaker_endpoint_deregister_scalable_target(resource_id):
+    target_input = {
+        "ServiceNamespace": "sagemaker",
+        "ResourceId": resource_id,
+        "ScalableDimension": "sagemaker:variant:DesiredInstanceCount", 
+    }
+
+    target_response = application_autoscaling_client().deregister_scalable_target(**target_input)
+    return target_response
+
+def sagemaker_endpoint_delete_scaling_policy(resource_id, policy_name):
+    policy_input = {
+        "ServiceNamespace": "sagemaker",
+        "ResourceId": resource_id,
+        "ScalableDimension": "sagemaker:variant:DesiredInstanceCount", 
+        "PolicyName": policy_name
+    }
+
+    policy_response = application_autoscaling_client().delete_scaling_policy(**policy_input)
+    return policy_response