Skip to content

Conversation

mattcreaser
Copy link
Member

Issue #, if available: #161

Description of changes:
Updates Liveness to work with 16kb page size

How did you test these changes?

  • Verified Liveness session can run on device with 16kb page size enabled.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners July 8, 2025 15:25
@tylerjroach
Copy link
Member

@mattcreaser What NDK version are you using? I noticed that in my initial work I had to add a line bumping NDK. I don't know if this was for CI, or Gradle version, but it may be something we need to pin.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (a3793d4) to head (a9ae194).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          97       97           
  Lines        4539     4539           
  Branches      530      530           
=======================================
  Hits         1443     1443           
  Misses       2980     2980           
  Partials      116      116           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcreaser
Copy link
Member Author

If it's unspecified (as it is for Liveness) then the default NDK version is set by the AGP version. For our AGP version of 8.7.2 the default NDK is r27.

@tylerjroach
Copy link
Member

Ah it would have been the AGP version that was the issue on the first attempt.

@mattcreaser mattcreaser merged commit 6abe43e into main Jul 9, 2025
5 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/liveness-16kb branch July 9, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants