Assertions must not be run outside of an active attempt

Though you may start multiple attempts.

Author: novemberborn

lib/test.js

@@ -313,6 +313,10 @@ class Test {
 			this.saveFirstError(new Error('Assertion passed, but test has already finished'));
 		}
 
+		if (this.pendingAttemptCount > 0) {
+			this.saveFirstError(new Error('Assertion passed, but an attempt is pending. Use the attempt’s assertions instead'));
+		}
+
 		this.assertCount++;
 		this.refreshTimeout();
 	}
@@ -326,6 +330,10 @@ class Test {
 			this.saveFirstError(new Error('Assertion started, but test has already finished'));
 		}
 
+		if (this.pendingAttemptCount > 0) {
+			this.saveFirstError(new Error('Assertion started, but an attempt is pending. Use the attempt’s assertions instead'));
+		}
+
 		this.assertCount++;
 		this.pendingAssertionCount++;
 		this.refreshTimeout();
@@ -343,6 +351,10 @@ class Test {
 			this.saveFirstError(new Error('Assertion failed, but test has already finished'));
 		}
 
+		if (this.pendingAttemptCount > 0) {
+			this.saveFirstError(new Error('Assertion failed, but an attempt is pending. Use the attempt’s assertions instead'));
+		}
+
 		this.assertCount++;
 		this.refreshTimeout();
 		this.saveFirstError(error);

test/test-try-commit.js

@@ -277,13 +277,13 @@ test('try-commit fails when plan is not reached inside the try', async t => {
 
 test('plan within try-commit is not affected by assertions outside', async t => {
 	const result = await ava(async a => {
+		a.is(1, 1);
+		a.is(2, 2);
+
 		const attempt = a.try(b => {
 			b.plan(3);
 		});
 
-		a.is(1, 1);
-		a.is(2, 2);
-
 		const res = await attempt;
 		t.false(res.passed);
 		res.commit();
@@ -559,3 +559,29 @@ test('assigning context in try-commit does not affect parent', async t => {
 
 	t.is(result.passed, true);
 });
+
+test('do not run assertions outside of an active attempt', async t => {
+	const passing = await ava(async a => {
+		await a.try(() => {});
+		a.pass();
+	}).run();
+
+	t.false(passing.passed);
+	t.match(passing.error.message, /Assertion passed, but an attempt is pending. Use the attempt’s assertions instead/);
+
+	const pending = await ava(async a => {
+		await a.try(() => {});
+		await a.throwsAsync(Promise.reject(new Error('')));
+	}).run();
+
+	t.false(pending.passed);
+	t.match(pending.error.message, /Assertion started, but an attempt is pending. Use the attempt’s assertions instead/);
+
+	const failing = await ava(async a => {
+		await a.try(() => {});
+		a.fail();
+	}).run();
+
+	t.false(failing.passed);
+	t.match(failing.error.message, /Assertion failed, but an attempt is pending. Use the attempt’s assertions instead/);
+});