Bug: Incorrect value-to-pointer usage in crypto/kzg4844/kzg4844_gokzg.go

[christiankakesa]

Host platform

Ubuntu 22.04.5 LTS x86_64 - go version go1.23.9 linux/amd64

What is the version of libevm

v1.13.14-0.2.0.release

What's the problem 🤔

There is a type mismatch in the kzg4844_gokzg.go file in the crypto/kzg4844 package. The library passes a value of type gokzg4844.Blob where a pointer (*gokzg4844.Blob) is required by context methods, which leads to compilation errors.

Share your logs if needed

# github.com/ava-labs/libevm/crypto/kzg4844
../../go/pkg/mod/github.com/ava-labs/libevm@v1.13.14-0.2.0.release/crypto/kzg4844/kzg4844_gokzg.go:52:49: cannot use (gokzg4844.Blob)(blob) (value of type gokzg4844.Blob) as *gokzg4844.Blob value in argument to context.BlobToKZGCommitment
../../go/pkg/mod/github.com/ava-labs/libevm@v1.13.14-0.2.0.release/crypto/kzg4844/kzg4844_gokzg.go:64:47: cannot use (gokzg4844.Blob)(blob) (value of type gokzg4844.Blob) as *gokzg4844.Blob value in argument to context.ComputeKZGProof
../../go/pkg/mod/github.com/ava-labs/libevm@v1.13.14-0.2.0.release/crypto/kzg4844/kzg4844_gokzg.go:86:44: cannot use (gokzg4844.Blob)(blob) (value of type gokzg4844.Blob) as *gokzg4844.Blob value in argument to context.ComputeBlobKZGProof
../../go/pkg/mod/github.com/ava-labs/libevm@v1.13.14-0.2.0.release/crypto/kzg4844/kzg4844_gokzg.go:97:36: cannot use (gokzg4844.Blob)(blob) (value of type gokzg4844.Blob) as *gokzg4844.Blob value in argument to context.VerifyBlobKZGProof

Share your configuration(s) if needed

[ARR4N]

Thanks for reporting this, @christiankakesa. I can't reproduce it with the version that libevm uses (0.7.0) and know that the function signatures were modified in a later version. Can you please share your go.sum entries for github.com/crate-crypto/go-kzg-4844?

[christiankakesa]

There is a change in libevm abigen which use now libevm/accounts/abi instead of coreth/accounts/abi, the error changed : /tmp/go-build/_cgo_export.c:27: multiple definition of secp256k1GoPanicIllegal'; /tmp/go-link-3345108124/000002.o:/tmp/go-build/_cgo_export.c:27: first defined here`

Here is the content of go.sum file.

module gamefi-evm

go 1.23

require (
	github.com/ava-labs/libevm v1.13.14-0.2.0.release
	github.com/ethereum-optimism/optimism/l2geth v0.0.0-20230612200230-50b04ade19e3
	github.com/ethereum/go-ethereum v1.13.8
	github.com/jxskiss/mcli v0.9.5
	github.com/mattn/go-colorable v0.1.13
	github.com/pkg/errors v0.9.1
	github.com/sirupsen/logrus v1.9.0
	github.com/spf13/pflag v1.0.5
	github.com/spf13/viper v1.12.0
	golang.org/x/crypto v0.21.0
)

require (
	github.com/DataDog/zstd v1.5.2 // indirect
	github.com/MakeNowJust/heredoc/v2 v2.0.1 // indirect
	github.com/Microsoft/go-winio v0.6.1 // indirect
	github.com/VictoriaMetrics/fastcache v1.12.1 // indirect
	github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847 // indirect
	github.com/bits-and-blooms/bitset v1.10.0 // indirect
	github.com/btcsuite/btcd v0.22.1 // indirect
	github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect
	github.com/cespare/xxhash/v2 v2.2.0 // indirect
	github.com/cockroachdb/errors v1.9.1 // indirect
	github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect
	github.com/cockroachdb/redact v1.1.3 // indirect
	github.com/consensys/bavard v0.1.13 // indirect
	github.com/consensys/gnark-crypto v0.12.1 // indirect
	github.com/crate-crypto/go-kzg-4844 v0.7.0 // indirect
	github.com/deckarep/golang-set v1.8.0 // indirect
	github.com/deckarep/golang-set/v2 v2.1.0 // indirect
	github.com/decred/dcrd/dcrec/secp256k1/v4 v4.1.0 // indirect
	github.com/elastic/gosigar v0.12.0 // indirect
	github.com/ethereum/c-kzg-4844 v0.4.0 // indirect
	github.com/frankban/quicktest v1.14.4 // indirect
	github.com/fsnotify/fsnotify v1.6.0 // indirect
	github.com/getsentry/sentry-go v0.18.0 // indirect
	github.com/go-ole/go-ole v1.3.0 // indirect
	github.com/go-stack/stack v1.8.1 // indirect
	github.com/golang/snappy v0.0.5-0.20220116011046-fa5810519dcb // indirect
	github.com/google/go-cmp v0.6.0 // indirect
	github.com/google/uuid v1.6.0 // indirect
	github.com/gorilla/websocket v1.5.0 // indirect
	github.com/hashicorp/hcl v1.0.0 // indirect
	github.com/holiman/uint256 v1.2.4 // indirect
	github.com/magiconair/properties v1.8.6 // indirect
	github.com/mattn/go-isatty v0.0.17 // indirect
	github.com/mitchellh/mapstructure v1.5.0 // indirect
	github.com/mmcloughlin/addchain v0.4.0 // indirect
	github.com/pelletier/go-toml v1.9.5 // indirect
	github.com/pelletier/go-toml/v2 v2.0.5 // indirect
	github.com/prometheus/client_golang v1.14.0 // indirect
	github.com/prometheus/common v0.42.0 // indirect
	github.com/prometheus/procfs v0.10.1 // indirect
	github.com/rogpeppe/go-internal v1.10.0 // indirect
	github.com/rs/cors v1.8.2 // indirect
	github.com/shirou/gopsutil v3.21.11+incompatible // indirect
	github.com/spf13/afero v1.8.2 // indirect
	github.com/spf13/cast v1.5.0 // indirect
	github.com/spf13/jwalterweatherman v1.1.0 // indirect
	github.com/steakknife/bloomfilter v0.0.0-20180922174646-6819c0d2a570 // indirect
	github.com/steakknife/hamming v0.0.0-20180906055917-c99c65617cd3 // indirect
	github.com/subosito/gotenv v1.3.0 // indirect
	github.com/supranational/blst v0.3.11 // indirect
	github.com/syndtr/goleveldb v1.0.1-0.20220614013038-64ee5596c38a // indirect
	github.com/tklauser/go-sysconf v0.3.12 // indirect
	github.com/tklauser/numcpus v0.6.1 // indirect
	github.com/yusufpapurcu/wmi v1.2.2 // indirect
	golang.org/x/exp v0.0.0-20231127185646-65229373498e // indirect
	golang.org/x/mod v0.14.0 // indirect
	golang.org/x/sync v0.6.0 // indirect
	golang.org/x/sys v0.18.0 // indirect
	golang.org/x/text v0.14.0 // indirect
	golang.org/x/tools v0.17.0 // indirect
	google.golang.org/protobuf v1.33.0 // indirect
	gopkg.in/ini.v1 v1.67.0 // indirect
	gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect
	gopkg.in/yaml.v2 v2.4.0 // indirect
	gopkg.in/yaml.v3 v3.0.1 // indirect
	rsc.io/tmplfunc v0.0.3 // indirect
)

[ARR4N]

/tmp/go-build/_cgo_export.c:27: multiple definition of secp256k1GoPanicIllegal'; /tmp/go-link-3345108124/000002.o:/tmp/go-build/_cgo_export.c:27: first defined here`

This is because your go.mod has both ava-labs/libevm and ethereum/go-ethereum, which provide the same packages and functionality. When you compile, it tries to compile the crypto package from both of them, which causes cgo problems.

You can fix this by either:

1. Change all of your imports of github.com/ethereum/go-ethereum/** to github.com/ava-labs/libevm/**; or
2. Add a replace directive to your go.mod file.

I don't have your repo to test it, but adding this line to your go.mod, deleting the go-ethereum line, and running go mod tidy should fix things:

replace github.com/ethereum/go-ethereum => github.com/ava-labs/libevm v1.13.14-0.2.0.release

Note that you're also using different versions of the two repos; 1.13.8 for geth and 1.13.14 for libevm. It should usually be ok to just upgrade, but you'll have to confirm for yourself as I don't know what you're using the packages for. You may need to make some minor changes if syntax was broken between the two versions.

module gamefi-evm

go 1.23

replace github.com/ethereum/go-ethereum => github.com/ava-labs/libevm v1.13.14-0.2.0.release

require (
	github.com/ava-labs/libevm v1.13.14-0.2.0.release
	github.com/ethereum-optimism/optimism/l2geth v0.0.0-20230612200230-50b04ade19e3
	github.com/jxskiss/mcli v0.9.5
	github.com/mattn/go-colorable v0.1.13
	github.com/pkg/errors v0.9.1
	github.com/sirupsen/logrus v1.9.0
	github.com/spf13/pflag v1.0.5
	github.com/spf13/viper v1.12.0
	golang.org/x/crypto v0.21.0
)

[christiankakesa]

Effectively, the app is not only for Avalanche C-Chain but BSC, Ethereum, and Marle network.
I'll add directives to go cflag or ldflag to ignore multiple header, or hide other node client to see if the first issue is solved or not.

I'll let you know quickly.

[christiankakesa]

Just by adding ldflags directives, no more issues and we don't have the the multiple definition error anymore.

go run --ldflags '-extldflags "-Wl,--allow-multiple-definition"' cmd/yieldyak/yieldyak.go

Abigen from libevm now generates the correct import: libevm/accounts/abi instead of coreth/accounts/abi. It looks good now.

To use abigen, I build it from the current main version of libevm, then regenerate the Go package from the smart contract ABI.

christian@MSI:~/workspace/swaper$ go run --ldflags '-extldflags "-Wl,--allow-multiple-definition"' cmd/yieldyak/yieldyak.go 
INFO   [2025-06-23T18:08:58+08:00] Yield.Start('XXX')                    
INFO   [2025-06-23T18:09:00+08:00] suggested GAS price: 0.769 nAVAX             
INFO   [2025-06-23T18:09:01+08:00] amount of AVAX to sell: 0.02500/10.69344 AVAX 
INFO   [2025-06-23T18:09:01+08:00] amount of WAVAX: 0.00020 WAVAX               
INFO   [2025-06-23T18:09:03+08:00] amount of XXX to buy : 1430963.580330232 XXX 
INFO   [2025-06-23T18:09:03+08:00] path: Wrapped AVAX -> XXX                   
INFO   [2025-06-23T18:09:04+08:00] adapters: TraderJoeYakAdapterV0
xxxxxxxxxxxxxxxxxxxxxxx

[christiankakesa]

Thank you @ARR4N

[ARR4N]

Just by adding ldflags directives, no more issues and we don't have the the multiple definition error anymore.

go run --ldflags '-extldflags "-Wl,--allow-multiple-definition"' cmd/yieldyak/yieldyak.go

This is very useful to know, thank you! I've wanted libevm tests to use modules that depend on geth but haven't been able to without this.

[nirav-patel-anchor]

@ARR4N is there any plan to upgrade github.com/crate-crypto/go-kzg-4844 in near future?

[ARR4N]

@ARR4N is there any plan to upgrade github.com/crate-crypto/go-kzg-4844 in near future?

No explicit plan but I may be able to cherry-pick if it's not too disruptive. What specifically are you looking for in the new version, @nirav-patel-anchor? Is there a PR on ethereum/go-ethereum in which they moved to a version that would be suitable for your needs?

[nirav-patel-anchor]

@ARR4N is there any plan to upgrade github.com/crate-crypto/go-kzg-4844 in near future?

No explicit plan but I may be able to cherry-pick if it's not too disruptive. What specifically are you looking for in the new version, @nirav-patel-anchor? Is there a PR on ethereum/go-ethereum in which they moved to a version that would be suitable for your needs?

We are facing conflict with this library where our code also uses ethereum/go-ethereum which uses v1.1.0 of go-kzg-4844. Since there was a breaking change in the lib, we cannot use ava-labs/avalanchego code, needed for parsing atomic transactions.

ethereum#29050 might be what is needed

[ARR4N]

ethereum#29050 might be what is needed

In principle I'm completely ok with incorporating this PR. I need to check what the practical implications are (e.g. does it break anything else?). Can you please open a new issue, @nirav-patel-anchor, so it's easier to track?

[nirav-patel-anchor]

sure I will create new issue

[nirav-patel-anchor]

tracking in #197. Appreciate quick responses @ARR4N 🙌