feat: project config view #1372

RonenMars · 2025-10-19T08:28:52Z

[## Description

Linear Ticket

What type of PR is this? (check all applicable)

💡 (feat) - A new feature (non-breaking change which adds functionality)
🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
🏎 (perf) - Optimization
📄 (docs) - Documentation - Documentation only changes
📄 (test) - Tests - Adding missing tests or correcting existing tests
⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
☑️ (chore) - Chores - Other changes that don't modify src or test files
↩️ (revert) - Reverts - Reverts a previous commit(s).

](feat: project config view)feat: project config view

Copilot

Pull Request Overview

This is a major refactoring PR that restructures the project navigation and configuration UI from a tab-based system to a drawer/sidebar-based architecture. The changes rename "Code & Assets" to "Files/Explorer", consolidate settings into a drawer, and improve the overall navigation experience.

Key Changes:

Migrated from tab-based navigation to a drawer-based sidebar architecture for project settings
Renamed "Code & Assets" to "Files" throughout the codebase
Replaced global drawer store with project-scoped drawer state in useSharedBetweenProjectsStore
Added new utility functions for navigation with settings preservation

Reviewed Changes

Copilot reviewed 189 out of 197 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/validations/coseAndAssets.schema.ts	Renamed schema from `codeAssetsSchema` to `codeFilesSchema`
src/validations/index.ts	Updated exports to use new schema name
src/store/useModalStore.ts	Enhanced modal store with per-modal data storage and getter function
src/store/useSharedBetweenProjectsStore.ts	Replaced chatbot-specific state with generic drawer management system
src/store/useProjectStore.ts	Removed `latestOpened` tracking state
src/utilities/navigation.ts	Added new navigation utilities for settings path preservation
src/utilities/fileTree.utils.ts	New utilities for building file trees and calculating optimal widths
src/components/organisms/projectSettingsView/*	New drawer-based project settings components
src/components/organisms/projectFiles/*	New file explorer sidebar component
src/routes.tsx	Updated routing structure to support settings drawer
src/locales/en/*	Updated translation keys from "code&assets" to "files"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T13:09:53Z

src/store/useModalStore.ts

+	modals: {
+		[ModalName.editConnection]: true,
+	},


The modal is set to forceOpen with [ModalName.editConnection]: true in the initial state. This means the edit connection modal will be open by default on application start, which is likely unintended behavior.

Copilot · 2025-11-06T13:09:53Z

src/components/organisms/editorTabs.tsx

-		if (resources && Object.values(resources || {}).length && !isLoadingCode && fileToOpen && !fileToOpenIsOpened) {
+		if (
+			resources &&
+			Object.values(resources || {}).length &&


This use of variable 'resources' always evaluates to true.

Copilot · 2025-11-06T13:09:53Z

src/components/organisms/topbar/project/manualRun/manualRunSettingsDrawer.tsx

 			});
 			LoggerService.error(namespaces.sessionsService, `${t("executionFailedExtended", { projectId, error })}`);
-			closeDrawer(DrawerName.projectManualRunSettings);
+			if (projectId) {


This use of variable 'projectId' always evaluates to true.

Copilot · 2025-11-06T13:09:54Z

src/components/organisms/topbar/project/manualRun/manualRunSettingsDrawer.tsx

 			type: "success",
 		});
-		closeDrawer(DrawerName.projectManualRunSettings);
+		if (projectId) {


This use of variable 'projectId' always evaluates to true.

Copilot

Pull Request Overview

Copilot reviewed 226 out of 398 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T18:35:52Z

src/constants/global.constants.ts

+export const connectionStatusCheckInterval = 1500;
+export const maxConnectionsCheckRetries = 600;


The retry count has been increased from 60 to 600, which could result in connection checks running for 15 minutes (600 × 1500ms). This is a significant increase that could lead to longer wait times and resource consumption. Consider whether this extended retry duration aligns with user experience expectations and whether a timeout mechanism should be documented.

Suggested change

export const connectionStatusCheckInterval = 1500;

export const maxConnectionsCheckRetries = 600;

export const connectionStatusCheckInterval = 1500;

// Maximum number of retries for connection status checks. With the current interval, this could result in up to 15 minutes of waiting (600 × 1500ms).

// Consider using connectionStatusCheckTimeout to limit the total wait time.

export const maxConnectionsCheckRetries = 600;

// Maximum total timeout for connection status checks (e.g., 2 minutes).

export const connectionStatusCheckTimeout = 120000;

Copilot · 2025-11-12T18:35:54Z

src/components/organisms/configuration/triggers/triggerInfoPopover.tsx

 	useEffect(() => {
+		if (!trigger) return;
+
+		const configureTriggerDisplay = async (trigger: Trigger) => {


The function configureTriggerDisplay is defined inside useEffect but lacks proper dependency tracking. The baseDetails dependency in the useEffect at line 83 is itself a useMemo that depends on trigger?.path and trigger?.entryFunction, which can cause the effect to run unnecessarily. Consider moving configureTriggerDisplay outside the effect or memoizing it with useCallback.

Copilot · 2025-11-12T18:35:55Z

src/components/organisms/configuration/variables/edit.tsx

+	const nameClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : "");
+	const valueClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : "");


These className computations are recalculated on every render. Since they depend on dirtyFields, consider using useMemo to avoid unnecessary recalculations, especially if the component re-renders frequently.

Suggested change

const nameClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : "");

const valueClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : "");

const nameClassName = React.useMemo(

() => cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : ""),

[dirtyFields["name"]]

);

const valueClassName = React.useMemo(

() => cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : ""),

[dirtyFields["value"]]

);

Copilot · 2025-11-12T18:35:56Z

src/components/organisms/configuration/connections/integrations/slack/add.tsx

+				(selectIntegrationSlack as SelectOption[]).splice(
+					selectIntegrationSlack.findIndex((opt) => opt.value === ConnectionAuthType.OauthDefault),
+					1,
+					{ label: "OAuth v2 - Default app", value: ConnectionAuthType.Oauth }
+				);


Directly mutating the imported selectIntegrationSlack array can cause unexpected side effects across the application, as this constant is shared. This mutation will persist across component re-renders and affect all uses of this constant. Create a new array instead of mutating the original.

Copilot · 2025-11-12T18:35:56Z

src/components/organisms/deployments/sessions/table/table.tsx

 			setIsInitialLoad(false);

-			if (!nextPageToken && data.sessions.length > 0) {
+			if (firstTimeLoading && !nextPageToken && data.sessions.length > 0) {


The condition checks firstTimeLoading but this variable is set to false inside the same conditional block at line 243. This creates a dependency on the order of execution and could lead to unexpected behavior if the logic changes. Consider restructuring to make the state transition more explicit.

Copilot · 2025-11-12T18:35:57Z

src/components/organisms/events/table.tsx

 	const fetchData = useCallback(async () => {
 		setIsSourceLoad(true);
-		await fetchEvents(true, sourceId, projectId);
+		await fetchEvents({ projectId, sourceId });


The fetchEvents call signature has changed from fetchEvents(true, sourceId, projectId) to fetchEvents({ projectId, sourceId }), but the implementation now passes an object instead of positional parameters. Ensure all callers of fetchEvents have been updated to use the new signature to avoid runtime errors.

…on text

RonenMars force-pushed the ronen/feat/project-assistant branch 2 times, most recently from 05d3206 to 246d041 Compare October 27, 2025 01:42

RonenMars force-pushed the ronen/feat/project-assistant branch from 73ede8d to 1b3d88b Compare November 4, 2025 06:37

RonenMars requested review from Copilot, haimzlato and mario99logic November 6, 2025 13:07

Copilot AI reviewed Nov 6, 2025

View reviewed changes

RonenMars force-pushed the ronen/feat/project-assistant branch 4 times, most recently from 7ed3701 to bf76484 Compare November 10, 2025 10:20

RonenMars added 19 commits November 10, 2025 13:12

feat: project config view

579520d

feat: project config view

8942a7a

feat: project config view

3ebe3da

feat: project config view

3598936

feat: project config view

05fd3e1

feat: project config view

e7c37dc

feat: project config view

e8c1436

feat: project config view

8155145

feat: project config view

30e229a

feat: project config view

7eeed60

feat: project config view

df5e3d1

feat: project config view

a9d8991

feat: project config view

c79e1f0

feat: project config view

76ed20a

feat: project config view

0c5be05

feat: version manager

e91af31

feat: project config view

48600b1

feat: project view refactored

9cb1fbe

feat: project view refactored

5f99966

RonenMars added 12 commits November 12, 2025 11:35

feat: project screen wip

c65fbea

feat: project screen wip

c13b9a6

feat: project screen wip

10c150b

feat: project screen wip

f0ce136

feat: project screen wip

9588452

feat: project screen wip

1f3b119

feat: project screen wip

9652ae8

feat: new project layout - fix e2e

a16c8d0

feat: project screen wip

a104dd2

feat: project screen - fix e2e tests

a1b8ad4

feat: project screen - fix e2e tests

a9f1e16

feat: project screen - fix e2e tests

ec5374b

RonenMars requested a review from Copilot November 12, 2025 18:33

Copilot AI reviewed Nov 12, 2025

View reviewed changes

RonenMars added 15 commits November 12, 2025 20:36

feat: project screen - fix e2e tests

abc8e8a

chore: update ak submodule

27e5150

feat: project screen - fix e2e wip - reduce timeout

81263f1

feat: project screen - fix e2e wip - add title to trigger delete button

9a34ff9

feat: project screen - fix e2e wip - add title to trigger delete butt…

b9a62ef

…on text

feat: project screen - fix e2e wip - fix trigger delete title and aria

d29ca49

feat: project screen - fix e2e tests

7ebf990

feat: project screen - fix e2e tests wip

928eb78

feat: project screen - fix long names

1120f64

feat: project screen - fix overlays of drawers

2cdc4e3

feat: project screen - fix quickstart tour

4b75e94

feat: project screen - fix e2e tests

8f69851

feat: project screen - run e2e tests in serial mode, instead of parallel

93f0eb6

feat: project page - fix e2e wip

363b142

feat: project page - fix e2e wip

0ae7698

itayd approved these changes Nov 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: project config view #1372

feat: project config view #1372

Uh oh!

RonenMars commented Oct 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

		export const connectionStatusCheckInterval = 1500;
		export const maxConnectionsCheckRetries = 600;

		const nameClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : "");
		const valueClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : "");

-	const nameClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : "");
-	const valueClassName = cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : "");
+	const nameClassName = React.useMemo(
+		() => cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["name"] ? "border-white" : ""),
+		[dirtyFields["name"]]
+	);
+	const valueClassName = React.useMemo(
+		() => cn("text-gray-300 placeholder:text-gray-1100", dirtyFields["value"] ? "border-white" : ""),
+		[dirtyFields["value"]]
+	);

feat: project config view #1372

Are you sure you want to change the base?

feat: project config view #1372

Uh oh!

Conversation

RonenMars commented Oct 19, 2025

Linear Ticket

What type of PR is this? (check all applicable)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants