Skip to content

Commit 15eb138

Browse files
jsleuthpat841
authored andcommitted
feat(build): add cast-to-string for comparisons
It will be safer to use String() rather than depend on the presence of toString() methods on the objects. This is believed to be a non-breaking change.
1 parent 93d13c5 commit 15eb138

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/AureliaDependenciesPlugin.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ParserPlugin {
4848
hooks.evaluateIdentifier.tap("imported var.moduleName", TAP_NAME, (expr: Webpack.MemberExpression) => {
4949
if (expr.property.name === "moduleName" &&
5050
expr.object.name === "PLATFORM" &&
51-
expr.object.type.toString() === "Identifier") {
51+
String(expr.object.type) === "Identifier") {
5252
return new BasicEvaluatedExpression().setIdentifier("PLATFORM.moduleName").setRange(expr.range);
5353
}
5454
return undefined;
@@ -62,8 +62,8 @@ class ParserPlugin {
6262
// PLATFORM.moduleName("id");
6363
hooks.evaluate.tap("MemberExpression", TAP_NAME, expr => {
6464
if (expr.property.name === "moduleName" &&
65-
(expr.object.type === "MemberExpression" && expr.object.property.name === "PLATFORM" ||
66-
expr.object.type.toString() === "Identifier" && expr.object.name === "PLATFORM")) {
65+
(String(expr.object.type) === "MemberExpression" && expr.object.property.name === "PLATFORM" ||
66+
String(expr.object.type) === "Identifier" && expr.object.name === "PLATFORM")) {
6767
return new BasicEvaluatedExpression().setIdentifier("PLATFORM.moduleName").setRange(expr.range);
6868
}
6969
return undefined;

0 commit comments

Comments
 (0)