Add sys implementation for gleam/otp
#1975
Merged
+1,073
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w46/add-sys
branch
3 times, most recently
from
3c7032e to
3209d11
Compare
- Factorize some `gen_server`/`gen_statem` code into new `gen` module - Extend `proc_lib` to add `start_monitor` and use it with `gen_server` - Bump CI erlfmt to v1.7.0 (v1.1.0 and v1.7.0 only disagree on newly introduce `gen` module's moduledoc attribute). - Remove unnecessary check in `timer_manager:maybe_start/0` as the same check is performed in `gen_server:start/4` Signed-off-by: Paul Guyot <[email protected]>
bettio
approved these changes
Nov 13, 2025
petermm
reviewed
Nov 13, 2025
| exit(Atom); | ||
| {MonitorRef, Reply} -> | ||
| demonitor(MonitorRef, [flush]), | ||
| Reply |
Contributor
There was a problem hiding this comment.
I believe this should be {ok, Reply}
https://github.com/erlang/otp/blob/47995dbaeaf2c54cf2e4e19823f4e94fe52854df/lib/stdlib/src/gen.erl#L247
%% Makes a synchronous call to a generic process.
%% Request is sent to the Pid, and the response must be
%% {Tag, Reply}.
I have rebased GenServer.ex to use this call and tests are failing..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proc_libto addstart_monitorand use it with gen_serverThese changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later