Add the possiblity to change the signature method (#1160)

h-braun · web-flow · commit 753408737a31 · 2023-05-13T18:44:26.000+03:00
* Add the possiblity to change the signature method

RSA_SHA512 was hardcoded in the REST Client for OAuth1.
It is now possible to change the 'Signature Method' in the 'oauth_dict'
with the key 'signature_method' to another signature.
The default value is kept as 'SIGNATURE_RSA' if no value for the
mentioned key is provided.

* Add the possiblity to change the signature method

RSA_SHA512 was hardcoded in the REST Client for OAuth1.
It is now possible to change the 'Signature Method' in the 'oauth_dict'
with the key 'signature_method' to another signature.
The default value is kept as 'SIGNATURE_RSA' if no value for the
mentioned key is provided.
diff --git a/atlassian/rest_client.py b/atlassian/rest_client.py
@@ -110,7 +110,7 @@ def _create_oauth_session(self, oauth_dict):
         oauth = OAuth1(
             oauth_dict["consumer_key"],
             rsa_key=oauth_dict["key_cert"],
-            signature_method=SIGNATURE_RSA,
+            signature_method=oauth_dict.get("signature_method", SIGNATURE_RSA),
             resource_owner_key=oauth_dict["access_token"],
             resource_owner_secret=oauth_dict["access_token_secret"],
         )

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ def _create_oauth_session(self, oauth_dict):`
`110`	`110`	`oauth = OAuth1(`
`111`	`111`	`oauth_dict["consumer_key"],`
`112`	`112`	`rsa_key=oauth_dict["key_cert"],`
`113`		`- signature_method=SIGNATURE_RSA,`
	`113`	`+ signature_method=oauth_dict.get("signature_method", SIGNATURE_RSA),`
`114`	`114`	`resource_owner_key=oauth_dict["access_token"],`
`115`	`115`	`resource_owner_secret=oauth_dict["access_token_secret"],`
`116`	`116`	`)`