crowd: require password as argument (#914)

Remove password autogeneration from user creation.
Secrets library is not supported till Python 3.6.

Signed-off-by: Martin Styk <[email protected]>

Author: StykMartin

atlassian/crowd.py

@@ -1,7 +1,5 @@
 # coding=utf-8
 import logging
-import string
-import secrets
 
 from .rest_client import AtlassianRestAPI
 
@@ -59,24 +57,20 @@ def user_activate(self, username):
 
         return self._user_change_status(username, True)
 
-    def user_create(self, username, active, first_name, last_name, display_name, email, password=None):
+    def user_create(self, username, active, first_name, last_name, display_name, email, password):
         """
         Create new user method
-        :param  active: bool: OPTIONAL: password can be auto-generated if not included
+        :param  active: bool:
         :param  username: string: username
         :param  active: bool:
         :param  first_name: string:
         :param  last_name: string:
         :param  display_name:  string:
         :param  email: string:
-        :param  password: string: OPTIONAL:
+        :param  password: string:
         :return:
         """
 
-        if not password:
-            characters = string.ascii_letters + string.punctuation + string.digits
-            password = "".join(secrets.choice(characters) for x in range(30))
-
         user_object = {
             "name": username,
             "password": {"value": password},

docs/crowd.rst

@@ -12,9 +12,6 @@ Manage users
     # Add user
     crowd.user_create(username, active, first_name, last_name, display_name, email, password)
 
-    # Add user with auto-generated password
-    crowd.user_create(username, active, first_name, last_name, display_name, email)
-
     # Deactive user
     crowd.user_deactivate(username)