Add --no-group support to CLI
#8477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/no-group
branch
from
5a3dc50 to
33d104d
Compare
zanieb
reviewed
Oct 22, 2024
crates/uv-cli/src/lib.rs
Outdated
| /// Exclude dependencies from the specified local dependency group. | ||
| /// | ||
| /// May be provided multiple times. | ||
| #[arg(long, conflicts_with("only_group"))] |
Member
There was a problem hiding this comment.
I don't think this conflicts? What if I do --only-group foo --only-group bar --no-group foo? Per previous discussions about overriding prior options, this seems nice to permit.
Member
Author
There was a problem hiding this comment.
Ok, I went back and forth on this.
Member
There was a problem hiding this comment.
I trust your judgement, I was just surprised.
Member
Author
There was a problem hiding this comment.
It just added a bit of complexity to the implementation, so I had punted it. Makes sense though.
zanieb
reviewed
Oct 22, 2024
| "#, | ||
| )?; | ||
|
|
||
| uv_snapshot!(context.filters(), context.sync().arg("--no-group").arg("foo"), @r###" |
Member
There was a problem hiding this comment.
What about a test for --group foo --no-group foo?
(not necessarily in this function)
zanieb
approved these changes
Oct 22, 2024
charliermarsh
force-pushed
the
charlie/no-group
branch
from
33d104d to
9c54dcc
Compare
Merged
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
## Summary Now that `default-groups` can include more than just `"dev"`, it makes sense to allow users to remove groups with `--no-group`.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Now that `default-groups` can include more than just `"dev"`, it makes sense to allow users to remove groups with `--no-group`.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Now that `default-groups` can include more than just `"dev"`, it makes sense to allow users to remove groups with `--no-group`.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Now that `default-groups` can include more than just `"dev"`, it makes sense to allow users to remove groups with `--no-group`.
zanieb
pushed a commit
that referenced
this pull request
Oct 25, 2024
## Summary Now that `default-groups` can include more than just `"dev"`, it makes sense to allow users to remove groups with `--no-group`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that
default-groupscan include more than just"dev", it makes sense to allow users to remove groups with--no-group.