Update Selenium version to v4.35.0 +semver: feature (#273)

mialeska · web-flow · commit c45cc404fe81 · 2025-08-26T14:25:47.000+02:00
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj b/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj
@@ -91,7 +91,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aquality.Selenium.Core" Version="3.4.0" />
+    <PackageReference Include="Aquality.Selenium.Core" Version="3.5.0" />
     <PackageReference Include="WebDriverManager" Version="2.17.6" />
   </ItemGroup>
 
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml b/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsHandling.cs b/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsHandling.cs
@@ -74,21 +74,6 @@ public DevToolsSession GetDevToolsSession()
             return session;
         }
 
-        /// <summary>
-        /// Creates a session to communicate with a browser using the Chromium Developer Tools debugging protocol.
-        /// </summary>
-        /// <param name="protocolVersion">The version of the Chromium Developer Tools protocol to use. 
-        /// Defaults to autodetect the protocol version for <see cref="ChromiumDriver"/>, V85 for FirefoxDriver.</param>
-        /// <returns>The active session to use to communicate with the Chromium Developer Tools debugging protocol.</returns>
-        [Obsolete("Use GetDevToolsSession(DevToolsOptions options)")]
-        public DevToolsSession GetDevToolsSession(int protocolVersion)
-        {
-            Logger.Info("loc.browser.devtools.session.get", protocolVersion);
-            var session = devToolsProvider.GetDevToolsSession(protocolVersion);
-            wasDevToolsSessionClosed = false;
-            return session;
-        }
-
         /// <summary>
         /// Creates a session to communicate with a browser using the Chromium Developer Tools debugging protocol.
         /// </summary>
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj
@@ -29,8 +29,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="nunit" Version="4.3.2" />
-    <PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
+    <PackageReference Include="nunit" Version="4.4.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="5.1.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/BrowserTabsTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/BrowserTabsTests.cs
@@ -142,7 +142,7 @@ public void Should_BePossibleTo_SwitchToNewByHandle_AndClose()
             });
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_SwitchToNewByIndex()
         {
             CheckSwitchingBy(3, () =>
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/BrowserTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/BrowserTests.cs
@@ -100,7 +100,7 @@ public void Should_BePossibleTo_ExecuteJavaScript()
             Assert.That(currentUrl, Is.EqualTo(dynamicContentForm.Url));
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_ExecuteAsyncJavaScript()
         {
             const int expectedDurationInSeconds = 1;
@@ -226,7 +226,7 @@ public void Should_BePossibleTo_GetBrowserName()
             Assert.That(AqualityServices.Browser.BrowserName, Is.EqualTo(browserName));
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_SetImplicitWait()
         {
             var browser = AqualityServices.Browser;
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs
@@ -5,7 +5,7 @@
 using Aquality.Selenium.Tests.Integration.TestApp.TheInternet.Forms;
 using NUnit.Framework;
 using OpenQA.Selenium;
-using OpenQA.Selenium.DevTools.V136.Emulation;
+using OpenQA.Selenium.DevTools.V139.Emulation;
 using System;
 using System.Collections.Generic;
 
@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec
         {
             void setAction(long width, long height, bool isMobile, double scaleFactor)
             {
-                var parameters = new OpenQA.Selenium.DevTools.V136.Emulation.SetDeviceMetricsOverrideCommandSettings
+                var parameters = new OpenQA.Selenium.DevTools.V138.Emulation.SetDeviceMetricsOverrideCommandSettings
                 {
-                    DisplayFeature = new OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeature
+                    DisplayFeature = new OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeature
                     {
-                        Orientation = OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeatureOrientationValues.Horizontal
+                        Orientation = OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeatureOrientationValues.Horizontal
                     },
                     Width = width,
                     Height = height,
@@ -93,7 +93,7 @@ private static void CheckDeviceMetricsOverride(Action<long, long, bool, double>
             Assert.That(getWindowHeight(), Is.EqualTo(initialValue), "Browser height should match to initial value after clear");
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_SetAndClearGeoLocationOverride()
         {
             CheckGeolocationOverride(
@@ -102,7 +102,7 @@ public void Should_BePossibleTo_SetAndClearGeoLocationOverride()
                 () => Assert.DoesNotThrowAsync(async () => await DevTools.ClearGeolocationOverride(), "Should be possible to clear geoLocation"));
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_SetAndClearGeoLocationOverride_ByExecutingCdpCommand()
         {
             CheckGeolocationOverride(
@@ -144,7 +144,7 @@ private static void CheckGeolocationOverride(Action<double?, double?, double?> s
             Assert.That(locationForm.Longitude, Is.EqualTo(defaultLongitude), "Longitude should match to default");
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_SetUserAgentAndLanguageOverride()
         {
             var defaultLanguage = new BrowserLanguageForm().Open().Value;
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/Elements/MultiChoiceBoxTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/Elements/MultiChoiceBoxTests.cs
@@ -34,7 +34,7 @@ public void Should_BePossibleTo_SelectAll()
             Assert.That(selectMultipleForm.ValuesFromResult, Is.EqualTo(selected));
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_DeselectByValue()
         {
             var valuesToRemove = new List<string> { "volvo", "saab" };
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/HiddenElementsTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/HiddenElementsTests.cs
@@ -49,7 +49,7 @@ public void Should_BePossibleTo_CheckThatHiddenElementsExist(
             });
         }
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_CheckThatHiddenElementsNotDisplayed(
             [ValueSource(nameof(ElementListProviders))] Func<ElementState, ElementsCount, IList<ILabel>> elementListProvider)
         {
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/ImageLocatorTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/ImageLocatorTests.cs
@@ -11,7 +11,7 @@ internal class ImageLocatorTests : UITest
     {
         private readonly BrokenImagesForm form = new();
 
-        [Test]
+        [Test, Category(RetriesGroup), Retry(RetriesCount)]
         public void Should_BePossibleTo_FindByImage()
         {
             new CheckBoxesForm().Open();
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/UITest.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/UITest.cs
@@ -8,6 +8,9 @@ namespace Aquality.Selenium.Tests.Integration
     [Parallelizable(ParallelScope.All)]
     internal class UITest
     {
+        protected const int RetriesCount = 5;
+        protected const string RetriesGroup = "Flaky";
+
         [TearDown]
         public void CleanUp()
         {

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ public void Should_BePossibleTo_SwitchToNewByHandle_AndClose()`
`142`	`142`	`});`
`143`	`143`	`}`
`144`	`144`
`145`		`- [Test]`
	`145`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`146`	`146`	`public void Should_BePossibleTo_SwitchToNewByIndex()`
`147`	`147`	`{`
`148`	`148`	`CheckSwitchingBy(3, () =>`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public void Should_BePossibleTo_ExecuteJavaScript()`
`100`	`100`	`Assert.That(currentUrl, Is.EqualTo(dynamicContentForm.Url));`
`101`	`101`	`}`
`102`	`102`
`103`		`- [Test]`
	`103`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`104`	`104`	`public void Should_BePossibleTo_ExecuteAsyncJavaScript()`
`105`	`105`	`{`
`106`	`106`	`const int expectedDurationInSeconds = 1;`
`@@ -226,7 +226,7 @@ public void Should_BePossibleTo_GetBrowserName()`
`226`	`226`	`Assert.That(AqualityServices.Browser.BrowserName, Is.EqualTo(browserName));`
`227`	`227`	`}`
`228`	`228`
`229`		`- [Test]`
	`229`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`230`	`230`	`public void Should_BePossibleTo_SetImplicitWait()`
`231`	`231`	`{`
`232`	`232`	`var browser = AqualityServices.Browser;`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`using Aquality.Selenium.Tests.Integration.TestApp.TheInternet.Forms;`
`6`	`6`	`using NUnit.Framework;`
`7`	`7`	`using OpenQA.Selenium;`
`8`		`-using OpenQA.Selenium.DevTools.V136.Emulation;`
	`8`	`+using OpenQA.Selenium.DevTools.V139.Emulation;`
`9`	`9`	`using System;`
`10`	`10`	`using System.Collections.Generic;`
`11`	`11`
`@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec`
`59`	`59`	`{`
`60`	`60`	`void setAction(long width, long height, bool isMobile, double scaleFactor)`
`61`	`61`	`{`
`62`		`- var parameters = new OpenQA.Selenium.DevTools.V136.Emulation.SetDeviceMetricsOverrideCommandSettings`
	`62`	`+ var parameters = new OpenQA.Selenium.DevTools.V138.Emulation.SetDeviceMetricsOverrideCommandSettings`
`63`	`63`	`{`
`64`		`- DisplayFeature = new OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeature`
	`64`	`+ DisplayFeature = new OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeature`
`65`	`65`	`{`
`66`		`- Orientation = OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeatureOrientationValues.Horizontal`
	`66`	`+ Orientation = OpenQA.Selenium.DevTools.V138.Emulation.DisplayFeatureOrientationValues.Horizontal`
`67`	`67`	`},`
`68`	`68`	`Width = width,`
`69`	`69`	`Height = height,`
`@@ -93,7 +93,7 @@ private static void CheckDeviceMetricsOverride(Action<long, long, bool, double>`
`93`	`93`	`Assert.That(getWindowHeight(), Is.EqualTo(initialValue), "Browser height should match to initial value after clear");`
`94`	`94`	`}`
`95`	`95`
`96`		`- [Test]`
	`96`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`97`	`97`	`public void Should_BePossibleTo_SetAndClearGeoLocationOverride()`
`98`	`98`	`{`
`99`	`99`	`CheckGeolocationOverride(`
`@@ -102,7 +102,7 @@ public void Should_BePossibleTo_SetAndClearGeoLocationOverride()`
`102`	`102`	`() => Assert.DoesNotThrowAsync(async () => await DevTools.ClearGeolocationOverride(), "Should be possible to clear geoLocation"));`
`103`	`103`	`}`
`104`	`104`
`105`		`- [Test]`
	`105`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`106`	`106`	`public void Should_BePossibleTo_SetAndClearGeoLocationOverride_ByExecutingCdpCommand()`
`107`	`107`	`{`
`108`	`108`	`CheckGeolocationOverride(`
`@@ -144,7 +144,7 @@ private static void CheckGeolocationOverride(Action<double?, double?, double?> s`
`144`	`144`	`Assert.That(locationForm.Longitude, Is.EqualTo(defaultLongitude), "Longitude should match to default");`
`145`	`145`	`}`
`146`	`146`
`147`		`- [Test]`
	`147`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`148`	`148`	`public void Should_BePossibleTo_SetUserAgentAndLanguageOverride()`
`149`	`149`	`{`
`150`	`150`	`var defaultLanguage = new BrowserLanguageForm().Open().Value;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public void Should_BePossibleTo_SelectAll()`
`34`	`34`	`Assert.That(selectMultipleForm.ValuesFromResult, Is.EqualTo(selected));`
`35`	`35`	`}`
`36`	`36`
`37`		`- [Test]`
	`37`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`38`	`38`	`public void Should_BePossibleTo_DeselectByValue()`
`39`	`39`	`{`
`40`	`40`	`var valuesToRemove = new List<string> { "volvo", "saab" };`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public void Should_BePossibleTo_CheckThatHiddenElementsExist(`
`49`	`49`	`});`
`50`	`50`	`}`
`51`	`51`
`52`		`- [Test]`
	`52`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`53`	`53`	`public void Should_BePossibleTo_CheckThatHiddenElementsNotDisplayed(`
`54`	`54`	`[ValueSource(nameof(ElementListProviders))] Func<ElementState, ElementsCount, IList<ILabel>> elementListProvider)`
`55`	`55`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ internal class ImageLocatorTests : UITest`
`11`	`11`	`{`
`12`	`12`	`private readonly BrokenImagesForm form = new();`
`13`	`13`
`14`		`- [Test]`
	`14`	`+ [Test, Category(RetriesGroup), Retry(RetriesCount)]`
`15`	`15`	`public void Should_BePossibleTo_FindByImage()`
`16`	`16`	`{`
`17`	`17`	`new CheckBoxesForm().Open();`