Skip to content

Tests of local appium DriverService were re-designed. #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2017
Merged

Tests of local appium DriverService were re-designed. #728

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea2c5c1
Tests of local appium DriverService were re-designed.
TikhomirovSergey Sep 16, 2017
61360cc
ServerBuilderTest: code improvement.
TikhomirovSergey Sep 17, 2017
c190315
ServerBuilderTest: magic strings were turned into final values
TikhomirovSergey Sep 17, 2017
2b86b18
ServerBuilderTest: magic strings were turned into final values
TikhomirovSergey Sep 17, 2017
916afef
ServerBuilderTest: the path resolving
TikhomirovSergey Sep 19, 2017
5e300d5
ServerBuilderTest: ip calculation was improved
TikhomirovSergey Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 47 additions & 37 deletions src/test/java/io/appium/java_client/service/local/ServerBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@
import static io.appium.java_client.service.local.flags.GeneralServerFlag.CALLBACK_ADDRESS;
import static io.appium.java_client.service.local.flags.GeneralServerFlag.PRE_LAUNCH;
import static io.appium.java_client.service.local.flags.GeneralServerFlag.SESSION_OVERRIDE;
import static java.lang.System.getProperty;
import static java.lang.System.setProperty;
import static java.util.Arrays.asList;
import static java.util.Optional.ofNullable;
import static java.util.concurrent.TimeUnit.SECONDS;
import static org.hamcrest.Matchers.greaterThan;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
Expand All @@ -38,18 +40,26 @@

public class ServerBuilderTest {

private static String pathToAppiumNodeInProperties;
/**
* It may be impossible to find the path to the instance of appium server due to different circumstance.
* So user may use environment variables/system properties to define the full path to the server
* appium.js that is supposed to be default.
*/
private static final String PATH_TO_APPIUM_NODE_IN_PROPERTIES = getProperty(APPIUM_PATH);
/**
* This is the path to the stub appium.js file
*/
private static final String PATH_T0_TEST_APPIUM_JS = "src/test/java/io/appium/java_client/service/local/appium.js";

private static String testIP;
private AppiumDriverLocalService service;
private File file;
private File testLogFile;
private OutputStream stream;

/**
* initialization.
*/
@BeforeClass public static void beforeClass() throws Exception {
pathToAppiumNodeInProperties = System.getProperty(APPIUM_PATH);

for (Enumeration<NetworkInterface> en = NetworkInterface.getNetworkInterfaces(); en
.hasMoreElements(); ) {
NetworkInterface intf = en.nextElement();
Expand All @@ -58,16 +68,16 @@ public class ServerBuilderTest {
InetAddress inetAddress = enumIpAddr.nextElement();
if (!inetAddress.isLoopbackAddress()) {
InetAddressValidator validator = InetAddressValidator.getInstance();
testIP = inetAddress.getHostAddress().toString();
if (validator.isValid(testIP)) {
break;
}
testIP = null;

testIP = ofNullable(testIP).orElseGet(() -> {
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as expected, because the iteration does not stop here even if testIP set. Please extract the loop into a separate method private static Optional<String> getTestIP(), so then beforeClass's body should look like testIP = getTestIP().orElseThrow(() -> new IllegalStateException("Cannot initialize the IP address for tests"))

String result = inetAddress.getHostAddress();
if (validator.isValid(result)) {
return result;
}
return null;
Copy link
Member

@SrinivasanTarget SrinivasanTarget Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return validator.isValid(result) ? result : null;

});
}
}
if (testIP != null) {
break;
}
}
}

Expand All @@ -79,14 +89,14 @@ public void tearDown() throws Exception {
stream.close();
}

ofNullable(file).ifPresent(fileArg -> {
if (file.exists()) {
file.delete();
ofNullable(testLogFile).ifPresent(savedTestLogFile -> {
if (savedTestLogFile.exists()) {
savedTestLogFile.delete();
}
});

System.clearProperty(APPIUM_PATH);
ofNullable(pathToAppiumNodeInProperties).ifPresent(s -> System.setProperty(APPIUM_PATH, s));
ofNullable(PATH_TO_APPIUM_NODE_IN_PROPERTIES).ifPresent(s -> setProperty(APPIUM_PATH, s));
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the constant cannot be null

Copy link
Contributor Author

@TikhomirovSergey TikhomirovSergey Sep 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach It may be null when the property was not defined

}

@Test public void checkAbilityToStartDefaultService() {
Expand All @@ -96,13 +106,13 @@ public void tearDown() throws Exception {
}

@Test public void checkAbilityToFindNodeDefinedInProperties() {
String definedNode = new File("src/test/java/io/appium/java_client/service/local/appium.js").getAbsolutePath();
String definedNode = new File(PATH_T0_TEST_APPIUM_JS).getAbsolutePath();
setProperty(APPIUM_PATH, definedNode);
assertThat(new File(new AppiumServiceBuilder().createArgs().get(0)), is(new File(definedNode)));
}

@Test public void checkAbilityToUseNodeDefinedExplicitly() {
File node = new File("src/test/java/io/appium/java_client/service/local/appium.js");
File node = new File(PATH_T0_TEST_APPIUM_JS);
AppiumServiceBuilder builder = new AppiumServiceBuilder().withAppiumJS(node);
assertThat(new File(builder.createArgs().get(0)).getAbsolutePath(), is(node.getAbsolutePath()));
}
Expand Down Expand Up @@ -174,24 +184,24 @@ public void tearDown() throws Exception {
}

@Test public void checkAbilityToChangeOutputStream() throws Exception {
file = new File("test");
file.createNewFile();
stream = new FileOutputStream(file);
testLogFile = new File("test");
testLogFile.createNewFile();
stream = new FileOutputStream(testLogFile);
service = buildDefaultService();
service.addOutPutStream(stream);
service.start();
assertTrue(file.length() > 0);
assertThat(testLogFile.length(), greaterThan(0L));
}

@Test public void checkAbilityToChangeOutputStreamAfterTheServiceIsStarted() throws Exception {
file = new File("test");
file.createNewFile();
stream = new FileOutputStream(file);
testLogFile = new File("test");
testLogFile.createNewFile();
stream = new FileOutputStream(testLogFile);
service = buildDefaultService();
service.start();
service.addOutPutStream(stream);
service.isRunning();
assertTrue(file.length() > 0);
assertThat(testLogFile.length(), greaterThan(0L));
}

@Test public void checkAbilityToShutDownService() {
Expand All @@ -215,12 +225,12 @@ public void tearDown() throws Exception {
}

@Test public void checkAbilityToStartServiceWithLogFile() throws Exception {
file = new File("Log.txt");
file.createNewFile();
service = new AppiumServiceBuilder().withLogFile(file).build();
testLogFile = new File("Log.txt");
testLogFile.createNewFile();
service = new AppiumServiceBuilder().withLogFile(testLogFile).build();
service.start();
assertTrue(file.exists());
assertTrue(file.length() > 0);
assertTrue(testLogFile.exists());
assertThat(testLogFile.length(), greaterThan(0L));
}

@Test public void checkAbilityToStartServiceWithPortUsingFlag() throws Exception {
Expand Down Expand Up @@ -270,22 +280,22 @@ public void tearDown() throws Exception {
}

@Test public void checkAbilityToStartServiceWithLogFileUsingFlag() throws Exception {
file = new File("Log2.txt");
testLogFile = new File("Log2.txt");

service = new AppiumServiceBuilder()
.withArgument(() -> "--log", file.getAbsolutePath())
.withArgument(() -> "--log", testLogFile.getAbsolutePath())
.build();
service.start();
assertTrue(file.exists());
assertTrue(testLogFile.exists());
}

@Test public void checkAbilityToStartServiceWithLogFileUsingShortFlag() throws Exception {
file = new File("Log3.txt");
testLogFile = new File("Log3.txt");

service = new AppiumServiceBuilder()
.withArgument(() -> "-g", file.getAbsolutePath())
.withArgument(() -> "-g", testLogFile.getAbsolutePath())
.build();
service.start();
assertTrue(file.exists());
assertTrue(testLogFile.exists());
}
}