-
-
Notifications
You must be signed in to change notification settings - Fork 765
Finalization of the Widget feature #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
da7a1a6
The refactoring of widget tests: The beginning
TikhomirovSergey 162fe15
The refactoring of widget tests: Stub webdriver/webelement
TikhomirovSergey 282fd34
The refactoring of widget tests: the WidgetTest interface
TikhomirovSergey 1e06afe
The refactoring of widget tests: Android widget tests were added
TikhomirovSergey a079f48
The refactoring of widget tests: All simple cases were implemented
TikhomirovSergey 1ceec6a
The refactoring of widget tests: lost parameters of the OverrideWidge…
TikhomirovSergey 4c92e82
The refactoring of widget tests: missed parameters of the OverrideWid…
TikhomirovSergey 30d0163
The refactoring of widget tests: WebDriverUnpackUtility is using HasS…
TikhomirovSergey 96ab7fd
The refactoring of widget tests: Test API was re-designed
TikhomirovSergey 5c960a4
The refactoring of widget tests: the test with fully combined widget …
TikhomirovSergey 0db6a30
The refactoring of widget tests: The final commit
TikhomirovSergey 73589c8
The refactoring of widget tests: work on remarks and codecy issues
TikhomirovSergey 94660c7
The refactoring of widget tests: work on remarks by @mykola-mokhnach
TikhomirovSergey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ | |
|
|
||
| import static io.appium.java_client.pagefactory.OverrideWidgetReader.getDefaultOrHTMLWidgetClass; | ||
| import static io.appium.java_client.pagefactory.OverrideWidgetReader.getMobileNativeWidgetClass; | ||
| import static java.util.Optional.ofNullable; | ||
|
|
||
| import org.openqa.selenium.By; | ||
|
|
||
|
|
@@ -26,7 +27,6 @@ | |
| import java.lang.reflect.ParameterizedType; | ||
| import java.lang.reflect.Type; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public class WidgetByBuilder extends DefaultElementByBuilder { | ||
|
|
||
|
|
@@ -92,12 +92,12 @@ private By getByFromDeclaredClass(WhatIsNeeded whatIsNeeded) { | |
| } | ||
|
|
||
| @Override protected By buildDefaultBy() { | ||
| return Optional.ofNullable(super.buildDefaultBy()) | ||
| return ofNullable(super.buildDefaultBy()) | ||
| .orElse(getByFromDeclaredClass(WhatIsNeeded.DEFAULT_OR_HTML)); | ||
| } | ||
|
|
||
| @Override protected By buildMobileNativeBy() { | ||
| return Optional.ofNullable(super.buildMobileNativeBy()) | ||
| return ofNullable(super.buildMobileNativeBy()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the |
||
| .orElse(getByFromDeclaredClass(WhatIsNeeded.MOBILE_NATIVE)); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather added this condition under single
IOS.equalsIgnoreCase(transformedPlatform)condition. One might forget about the fact, that conditions order matters here, having the current implementation.