feat: dynamic actor loading is enabled by default #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-ai
MQ37
requested changes
Jun 18, 2025
Contributor
MQ37
left a comment
MQ37
left a comment
There was a problem hiding this comment.
integration tests are failing, please check with APIFY_TOKEN="your token" npm run test:integration and fix them
jirispilka
requested changes
Jun 18, 2025
Collaborator
jirispilka
left a comment
jirispilka
left a comment
There was a problem hiding this comment.
Please see my comments here
…ble-dynamic-actor-loading
MichalKalita
commented
Jun 20, 2025
| input.enableAddingActors = input.enableActorAutoLoading === true || input.enableActorAutoLoading === 'true'; | ||
| } else { | ||
| input.enableAddingActors = false; | ||
| input.enableAddingActors = true; |
Contributor
Author
There was a problem hiding this comment.
This simple update changes the logic in apify-mcp-server. When the setting is not set, it's enabled by default. If it is set (by URL or config object), it uses the value as before.
Contributor
Author
|
Tests are updated, and all should pass. |
MQ37
reviewed
Jun 20, 2025
Contributor
MQ37
left a comment
MQ37
left a comment
There was a problem hiding this comment.
please add test case for disabling the Actor adding tools by passing false and check if they are actually NOT loaded, otherwise LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #144