Skip to content

fix: explicitly clear resources #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

fix: explicitly clear resources #136

merged 2 commits into from
Jun 13, 2025

Conversation

@jirispilka
Copy link
Collaborator

@jirispilka jirispilka commented Jun 11, 2025

Explicitly clear resources in close() function. But it might not help with memory leak (unless there was some handler registered)

@jirispilka jirispilka requested a review from MichalKalita June 11, 2025 02:44
@github-actions github-actions bot added the t-ai Issues owned by the AI team. label Jun 11, 2025
@jirispilka jirispilka requested a review from MQ37 June 13, 2025 00:25
MQ37
MQ37 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jirispilka jirispilka merged commit 779d2ba into master Jun 13, 2025
2 checks passed
@jirispilka jirispilka deleted the fix/explicitly-clear-resources branch June 13, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MQ37 MQ37 MQ37 approved these changes

+1 more reviewer

@MichalKalita MichalKalita MichalKalita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jirispilka jirispilka

Labels

t-ai Issues owned by the AI team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jirispilka @MichalKalita @MQ37