Update parent POM to 45 (#284)

And related fixes:
* POM add missing deps
* move to Maven 3 p-u, drop p-x
* test: checkstyle fixes

Author: cstamas

pgp-keys-map.list

@@ -30,5 +30,4 @@ org.apache.maven.shared:maven-invoker = 0x84789D24DF77A32433CE1F079EB80E92EB2135
 org.apache.maven.shared:maven-shared-utils = 0x84789D24DF77A32433CE1F079EB80E92EB2135B1
 org.codehaus.plexus:plexus-classworlds = 0xB91AB7D2121DC6B0A61AA182D7742D58455ECC7C
 org.codehaus.plexus:plexus-component-annotations = 0xFA77DCFEF2EE6EB2DEBEDD2C012579464D01C06A
-org.codehaus.plexus:plexus-utils = 0x84789D24DF77A32433CE1F079EB80E92EB2135B1
-org.codehaus.plexus:plexus-xml = 0x84789D24DF77A32433CE1F079EB80E92EB2135B1
+org.codehaus.plexus:plexus-utils = 0x32118CF76C9EC5D918E54967CA80D1F0EB6CA4BA

pom.xml

@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-plugins</artifactId>
-    <version>43</version>
+    <version>45</version>
     <relativePath />
   </parent>
 
@@ -133,15 +133,13 @@ under the License.
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
+      <version>${version.maven-plugin-tools}</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-utils</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>org.codehaus.plexus</groupId>
-      <artifactId>plexus-xml</artifactId>
+      <version>3.6.0</version>
     </dependency>
     <dependency>
       <groupId>org.bouncycastle</groupId>
@@ -243,7 +241,6 @@ under the License.
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-invoker-plugin</artifactId>
-          <version>3.9.0</version>
         </plugin>
         <plugin>
           <groupId>org.simplify4u.plugins</groupId>

src/test/java/org/apache/maven/plugins/gpg/it/BcSignArtifactIT.java

@@ -26,7 +26,9 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class BcSignArtifactIT extends ITSupport {
     public static Collection<Object[]> data() {

src/test/java/org/apache/maven/plugins/gpg/it/InvokerTestUtils.java

@@ -80,7 +80,7 @@ public static BuildResult executeRequest(
 
         final File buildLog =
                 new File(request.getBaseDirectory(request.getPomFile().getParentFile()), "build.log");
-        try (final PrintStream buildLogStream = new PrintStream(buildLog)) {
+        try (PrintStream buildLogStream = new PrintStream(buildLog)) {
             final InvocationOutputHandler buildLogOutputHandler = new PrintStreamHandler(buildLogStream, false);
             final InvokerLogger logger = new PrintStreamLogger(buildLogStream, InvokerLogger.DEBUG);