Skip to content

Warning about old enforcer api in rule implementation #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2025
Merged

Warning about old enforcer api in rule implementation #894

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ec7cd8
Warning about old enforcer api in rule implementation
slawekjaranowski Jun 22, 2025
bb199d8
fix message
slawekjaranowski Jun 24, 2025
49b5f88
fix message
slawekjaranowski Jun 26, 2025
c229a69
fix spotless
slawekjaranowski Jun 26, 2025
f738ab2
fix uppercase in version
slawekjaranowski Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ public List<EnforcerRuleDesc> createRules(PlexusConfiguration rules, Log log) th
// we need rule level before configuration in order to proper set logger
EnforcerLevel ruleLevel = getRuleLevelFromConfig(ruleConfig);

EnforcerRuleDesc ruleDesc = createRuleDesc(ruleConfig.getName(), ruleConfig.getAttribute("implementation"));
EnforcerRuleDesc ruleDesc =
createRuleDesc(ruleConfig.getName(), ruleConfig.getAttribute("implementation"), log);
// setup logger before rule configuration
ruleDesc.getRule().setLog(ruleLevel == EnforcerLevel.ERROR ? enforcerLoggerError : enforcerLoggerWarn);
if (ruleConfig.getChildCount() > 0) {
Expand All @@ -130,7 +131,8 @@ private EnforcerLevel getRuleLevelFromConfig(PlexusConfiguration ruleConfig) {
return EnforcerLevel.valueOf(level);
}

private EnforcerRuleDesc createRuleDesc(String name, String implementation) throws EnforcerRuleManagerException {
private EnforcerRuleDesc createRuleDesc(String name, String implementation, Log log)
throws EnforcerRuleManagerException {

// component name should always start at lowercase character
String ruleName = Character.toLowerCase(name.charAt(0)) + name.substring(1);
Expand All @@ -156,6 +158,8 @@ private EnforcerRuleDesc createRuleDesc(String name, String implementation) thro
}

try {
log.warn("ruleName " + ruleName + " with implementation " + ruleClass
+ "use deprecated enforcer API - contact the rule maintainer to fix it");
return new EnforcerRuleDesc(
ruleName, (EnforcerRuleBase) Class.forName(ruleClass).newInstance());
} catch (Exception e) {
Expand Down