Warning about old enforcer api in rule implementation (#894)

* Warning about old enforcer api in rule implementation

external rules should use a new enforcer api

* fix message

Co-authored-by: Tamas Cservenak <[email protected]>

* fix message

Co-authored-by: Matthias Bünger <[email protected]>

* fix spotless

* fix uppercase in version

---------

Co-authored-by: Tamas Cservenak <[email protected]>
Co-authored-by: Matthias Bünger <[email protected]>

Author: 3 people

maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java

@@ -107,7 +107,8 @@ public List<EnforcerRuleDesc> createRules(PlexusConfiguration rules, Log log) th
             // we need rule level before configuration in order to proper set logger
             EnforcerLevel ruleLevel = getRuleLevelFromConfig(ruleConfig);
 
-            EnforcerRuleDesc ruleDesc = createRuleDesc(ruleConfig.getName(), ruleConfig.getAttribute("implementation"));
+            EnforcerRuleDesc ruleDesc =
+                    createRuleDesc(ruleConfig.getName(), ruleConfig.getAttribute("implementation"), log);
             // setup logger before rule configuration
             ruleDesc.getRule().setLog(ruleLevel == EnforcerLevel.ERROR ? enforcerLoggerError : enforcerLoggerWarn);
             if (ruleConfig.getChildCount() > 0) {
@@ -130,7 +131,8 @@ private EnforcerLevel getRuleLevelFromConfig(PlexusConfiguration ruleConfig) {
         return EnforcerLevel.valueOf(level);
     }
 
-    private EnforcerRuleDesc createRuleDesc(String name, String implementation) throws EnforcerRuleManagerException {
+    private EnforcerRuleDesc createRuleDesc(String name, String implementation, Log log)
+            throws EnforcerRuleManagerException {
 
         // component name should always start at lowercase character
         String ruleName = Character.toLowerCase(name.charAt(0)) + name.substring(1);
@@ -156,6 +158,9 @@ private EnforcerRuleDesc createRuleDesc(String name, String implementation) thro
         }
 
         try {
+            log.warn(
+                    "ruleName " + ruleName + " with implementation " + ruleClass
+                            + "uses the deprecated Maven Enforcer Plugin API. This will not be supported in a future version of the plugin. Please contact the rule maintainer to upgrade the rule implementation to the current API.");
             return new EnforcerRuleDesc(
                     ruleName, (EnforcerRuleBase) Class.forName(ruleClass).newInstance());
         } catch (Exception e) {