Skip to content

Commit 908049f

Browse files
authored
MINOR: add a test for Protocol (#20169)
see #19769 (comment) This patch adds a test to `ProtocolTest` to ensure the Protocol page displays the correct API version range. Reviewers: Yung <[email protected]>, TengYao Chi <[email protected]>, Gaurav Narula <[email protected]>, Ken Huang <[email protected]>, Jimmy Wang <[email protected]>
1 parent 1b351ad commit 908049f

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

clients/src/test/java/org/apache/kafka/common/protocol/ProtocolTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import org.junit.jupiter.api.Test;
2020

2121
import static org.junit.jupiter.api.Assertions.assertFalse;
22+
import static org.junit.jupiter.api.Assertions.assertTrue;
2223

2324
public class ProtocolTest {
2425

@@ -27,6 +28,18 @@ public void testToHtml() {
2728
var html = Protocol.toHtml();
2829
assertFalse(html.isBlank());
2930
assertFalse(html.contains("LeaderAndIsr"), "Removed LeaderAndIsr should not show in HTML");
31+
32+
String requestVersion;
33+
String responseVersion;
34+
for (ApiKeys key : ApiKeys.clientApis()) {
35+
for (short version = key.oldestVersion(); version <= key.latestVersion(); version++) {
36+
requestVersion = key.name + " Request (Version: " + version;
37+
responseVersion = key.name + " Response (Version: " + version;
38+
39+
assertTrue(html.contains(requestVersion), "Missing request header for " + key.name + " version:" + version);
40+
assertTrue(html.contains(responseVersion), "Missing response header for " + key.name + " version:" + version);
41+
}
42+
}
3043
}
3144

3245
}

0 commit comments

Comments
 (0)