Enable comments on datafusion-site via giscus #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb please take a look when you get a chance |
|
we can look to disable it for localhost, only enable the comment for |
alamb
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
I tried it out, and it seems to work well: #95 (comment)
I also reviewed giscuss https://giscus.app/ and it seems very compatible with the ASF usage (no tracking, free for ever, etc).
Thank you very much @kevinjqliu for making this happen
|
FYI @timsaucer and @Omega359 and @andygrove |
alamb
approved these changes
Jul 24, 2025
| Enable giscuss comments: Allows comments on the blogs posted as | ||
| https://github.com/apache/datafusion-site/discussions | ||
|
|
||
| More details on https://github.com/apache/datafusion-site/issues/80 |
There was a problem hiding this comment.
I added some comments here to help people find the original issue / context for this feature
Thank you @kevinjqliu -- this is really cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
We've enabled the discussion section in repo in #85
Apache infra installed the giscus app to the repo in https://issues.apache.org/jira/browse/INFRA-26989
Heres the giscus config:
I was able to run the site locally,
And verified that this works! #94