Fix FFI errors, and add script for running TPC-H #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
changed the title
18 tasks
edmondop
reviewed
Oct 6, 2024
| sql = sql.strip() | ||
| if len(sql) > 0: | ||
| print(f"Executing: {sql}") | ||
| rows = ctx.sql(sql) |
Contributor
There was a problem hiding this comment.
How does this time relate to the fact that the context only wait for the first partition ? see https://github.com/apache/datafusion-ray/blob/main/datafusion_ray/context.py#L234
is there always a single partition?
Member
Author
There was a problem hiding this comment.
Yes, the final query stage always has a single output partition. You can verify this by looking at the expected plans in the repo.
Member
Author
|
I will go ahead and merge this since the current main branch is broken without this FFI fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Changes in this PR:
I can now run TPC-H and see tasks distributed across both nodes in my Ray cluster.