Don't make class SementicContext::Empty final.

hzeller · hzeller · commit 2fd71462cbd4 · 2022-07-06T08:56:53.000-07:00
The class does not implement the pure virtual methods so can not be considered 'final'. Clang 10 and 11 complain about this. Context: chipsalliance/Surelog#3081 Signed-off-by: Henner Zeller <h.zeller@acm.org>
diff --git a/runtime/Cpp/runtime/src/atn/SemanticContext.h b/runtime/Cpp/runtime/src/atn/SemanticContext.h
@@ -92,7 +92,7 @@ namespace atn {
     return !operator==(lhs, rhs);
   }
 
-  class ANTLR4CPP_PUBLIC SemanticContext::Empty final : public SemanticContext{
+  class ANTLR4CPP_PUBLIC SemanticContext::Empty : public SemanticContext{
   public:
     /**
      * The default {@link SemanticContext}, which is semantically equivalent to

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ namespace atn {`
`92`	`92`	`return !operator==(lhs, rhs);`
`93`	`93`	`}`
`94`	`94`
`95`		`- class ANTLR4CPP_PUBLIC SemanticContext::Empty final : public SemanticContext{`
	`95`	`+ class ANTLR4CPP_PUBLIC SemanticContext::Empty : public SemanticContext{`
`96`	`96`	`public:`
`97`	`97`	`/**`
`98`	`98`	`* The default {@link SemanticContext}, which is semantically equivalent to`