Mnale/correction meshinfo (#1038)

* Update the mesh_info : making more pythonic functionnalities

* Unable tests for older version of gate and gatebin with no implementation of Get_PinDerivedClassName API

* Update the PR : reformat code

* Update the PR : even more pythonic methods

Author: MichaelNale

src/ansys/dpf/core/mesh_info.py

@@ -131,7 +131,7 @@ def set_property(self, property_name, prop):
         return self.generic_data_container.set_property(property_name, prop)
 
     @property
-    def get_number_nodes(self):
+    def number_nodes(self):
         """
         Returns
         -------
@@ -142,7 +142,7 @@ def get_number_nodes(self):
         return self.generic_data_container.get_property("num_nodes")
 
     @property
-    def get_number_elements(self):
+    def number_elements(self):
         """
         Returns
         -------
@@ -153,7 +153,7 @@ def get_number_elements(self):
         return self.generic_data_container.get_property("num_elements")
 
     @property
-    def get_splittable_by(self):
+    def splittable_by(self):
         """
         Returns
         -------
@@ -164,7 +164,7 @@ def get_splittable_by(self):
         return self.generic_data_container.get_property("splittable_by")
 
     @property
-    def get_available_elem_types(self):
+    def available_elem_types(self):
         """
         Returns
         -------
@@ -174,22 +174,26 @@ def get_available_elem_types(self):
 
         return self.generic_data_container.get_property("avalaible_elem_type")
 
-    def set_number_nodes(self, number_of_nodes):
+    @number_nodes.setter
+    def number_nodes(self, value):
         """Set the number of nodes in the mesh"""
 
-        return self.generic_data_container.set_property("num_nodes", number_of_nodes)
+        self.generic_data_container.set_property("num_nodes", value)
 
-    def set_number_elements(self, number_of_elements):
+    @number_elements.setter
+    def number_elements(self, value):
         """Set the number of elements in the mesh"""
 
-        return self.generic_data_container.set_property("num_elements", number_of_elements)
+        self.generic_data_container.set_property("num_elements", value)
 
-    def set_splittable_by(self, split):
+    @splittable_by.setter
+    def splittable_by(self, value):
         """Set name of the properties according to which the mesh can be split by"""
 
-        return self.generic_data_container.set_property("splittable_by", split)
+        self.generic_data_container.set_property("splittable_by", value)
 
-    def set_available_elem_types(self, available_elem_types):
+    @available_elem_types.setter
+    def available_elem_types(self, value):
         """Set the available element types"""
 
-        return self.generic_data_container.set_property("avalaible_elem_type", available_elem_types)
+        self.generic_data_container.set_property("avalaible_elem_type", value)

src/ansys/dpf/core/operator_specification.py

@@ -383,7 +383,9 @@ def _fill_pins(self, binput, to_fill):
                 ]
 
                 pin_derived_class_type_name = ""
-                if server_meet_version("7.0", self._server):
+                if server_meet_version("7.0", self._server) and hasattr(
+                    self._api, "operator_specification_get_pin_derived_class_type_name"
+                ):
                     pin_derived_class_type_name = (
                         self._api.operator_specification_get_pin_derived_class_type_name(
                             self, binput, i_pin
@@ -614,7 +616,9 @@ def inputs(self) -> dict:
     def inputs(self, val: dict):
         for key, value in val.items():
             list_types = integral_types.MutableListString(value.type_names)
-            if server_meet_version("7.0", self._server):
+            if server_meet_version("7.0", self._server) and hasattr(
+                self._api, "operator_specification_set_pin_derived_class"
+            ):
                 self._api.operator_specification_set_pin_derived_class(
                     self,
                     True,
@@ -655,7 +659,9 @@ def outputs(self) -> dict:
     def outputs(self, val: dict):
         for key, value in val.items():
             list_types = integral_types.MutableListString(value.type_names)
-            if server_meet_version("7.0", self._server):
+            if server_meet_version("7.0", self._server) and hasattr(
+                self._api, "operator_specification_set_pin_derived_class"
+            ):
                 self._api.operator_specification_set_pin_derived_class(
                     self,
                     False,

tests/test_mesh_info.py

@@ -84,12 +84,12 @@ def test_set_get_num_of(server_type):
     mesh_info = dpf.MeshInfo(server=server_type)
     # """Number of nodes"""
     num_nodes = 189
-    mesh_info.set_number_nodes(189)
-    assert mesh_info.get_number_nodes == num_nodes
+    mesh_info.number_nodes = 189
+    assert mesh_info.number_nodes == num_nodes
     # """ Number of elements """
     num_elements = 2
-    mesh_info.set_number_elements(2)
-    assert mesh_info.get_number_elements == num_elements
+    mesh_info.number_elements = 2
+    assert mesh_info.number_elements == num_elements
 
 
 @pytest.mark.skipif(
@@ -122,8 +122,8 @@ def test_set_get_splittable_by_mesh_info(server_type):
     splittable = dpf.StringField(server=server_type)
     expected_splittable = ["split_01", "split_02", "split_03"]
     splittable.append(expected_splittable, 1)
-    mesh_info.set_splittable_by(splittable)
-    result_splittable = mesh_info.get_splittable_by
+    mesh_info.splittable_by = splittable
+    result_splittable = mesh_info.splittable_by
     assert result_splittable.data[0] == expected_splittable[0]
     assert result_splittable.data[1] == expected_splittable[1]
     assert result_splittable.data[2] == expected_splittable[2]
@@ -138,8 +138,8 @@ def test_set_get_available_elem_types_mesh_info(server_type):
     available_results_ids = [1, 2, 3]
     available_results = dpf.Scoping(server=server_type)
     available_results._set_ids(available_results_ids)
-    mesh_info.set_available_elem_types(available_results)
-    result_available = mesh_info.get_available_elem_types
+    mesh_info.available_elem_types = available_results
+    result_available = mesh_info.available_elem_types
     for x in range(len(available_results)):
         assert result_available.id(x) == available_results.id(x)