postgresql_query: fix the module cannot handle files with \n at the end (#192)

Co-authored-by: Douglas J Hunley <[email protected]>

Author: Andersson007

changelogs/fragments/0-postgresql_query_fix.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- postgresql_query - cannot handle .sql file with \n at end of file (https://github.com/ansible-collections/community.postgresql/issues/180).

plugins/modules/postgresql_query.py

@@ -363,6 +363,14 @@ def set_search_path(cursor, search_path):
     cursor.execute('SET search_path TO %s' % search_path)
 
 
+def insane_query(string):
+    for c in string:
+        if c not in (' ', '\n', '', '\t'):
+            return False
+
+    return True
+
+
 def main():
     argument_spec = postgres_common_argument_spec()
     argument_spec.update(
@@ -424,7 +432,11 @@ def main():
                     module.deprecate(msg=depr_msg, version="3.0.0", collection_name="community.postgresql")
 
                     if ';' in query:
-                        query_list = [q for q in query.split(';') if q != '\n']
+                        for q in query.split(';'):
+                            if insane_query(q):
+                                continue
+                            else:
+                                query_list.append(q)
                     else:
                         query_list.append(query)
                 else:

tests/integration/targets/postgresql_query/files/test0.sql

@@ -2,3 +2,5 @@ SELECT version();
 
 SELECT story FROM test_table
   WHERE id = %s OR story = 'Данные';
+ 
+

tests/integration/targets/postgresql_query/tasks/postgresql_query_initial.yml

@@ -59,17 +59,17 @@
     positional_args:
     - 1
     encoding: UTF-8
+    as_single_query: no
   register: result
   ignore_errors: true
   when: sql_file_created
 
 - assert:
     that:
     - result is not changed
-    - result.query == "SELECT version();\n\nSELECT story FROM test_table\n  WHERE id = 1 OR story = 'Данные';\n"
+    - result.query == "\n\nSELECT story FROM test_table\n  WHERE id = 1 OR story = 'Данные'"
     - result.query_result[0].story == 'first'
-    - result.query_all_results[0][0].story == 'first'
-    - result.rowcount == 1
+    - result.rowcount == 2
     - result.statusmessage == 'SELECT 1' or result.statusmessage == 'SELECT'
   when: sql_file_created