aws_ssm - Add gather_facts to integration tests for connection plugins (#1670) (#1675)

patchback[bot] · web-flow · commit 026534a13a23 · 2023-01-23T15:59:56.000Z
[PR #1670/93c2485c backport][stable-5] aws_ssm - Add gather_facts to integration tests for connection plugins This is a backport of PR #1670 as merged into main (93c2485). Depends-On: ansible/ansible-zuul-jobs#1752 SUMMARY gather_facts stalling out was one of the examples given for things broken with aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
diff --git a/changelogs/fragments/aws_ssm-facts.yml b/changelogs/fragments/aws_ssm-facts.yml
@@ -0,0 +1,2 @@
+trivial:
+- aws_ssm - Added gather_facts to connection plugin tests.
diff --git a/tests/integration/targets/connection/test_connection.yml b/tests/integration/targets/connection/test_connection.yml
@@ -10,6 +10,10 @@
 
   ### test wait_for_connection plugin
   - wait_for_connection:
+      timeout: '{{ wait_for_timeout | default(100) }}'
+
+  - name: Gather facts
+    ansible.builtin.setup:
 
   ### raw with unicode arg and output
 
diff --git a/tests/integration/targets/connection_aws_ssm_addressing/aliases b/tests/integration/targets/connection_aws_ssm_addressing/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_amazon/aliases b/tests/integration/targets/connection_aws_ssm_amazon/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_encrypted_s3/aliases b/tests/integration/targets/connection_aws_ssm_encrypted_s3/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_fedora/aliases b/tests/integration/targets/connection_aws_ssm_fedora/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_ssm_document/aliases b/tests/integration/targets/connection_aws_ssm_ssm_document/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_ubuntu/aliases b/tests/integration/targets/connection_aws_ssm_ubuntu/aliases
@@ -1,4 +1,4 @@
-time=20m
+time=10m
 
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_windows/aliases b/tests/integration/targets/connection_aws_ssm_windows/aliases
@@ -1,5 +1,4 @@
-time=20m
+time=10m
 
-unstable
 cloud/aws
 connection_aws_ssm
diff --git a/tests/integration/targets/connection_aws_ssm_windows/aws_ssm_integration_test_setup.yml b/tests/integration/targets/connection_aws_ssm_windows/aws_ssm_integration_test_setup.yml
@@ -3,3 +3,4 @@
     - role: ../setup_connection_aws_ssm
       vars:
         target_os: windows
+        wait_for_timeout: 200

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+trivial:`
	`2`	`+- aws_ssm - Added gather_facts to connection plugin tests.`