Skip to content

Commit 520caca

Browse files
committed
refactor: avoid confusion from runtime console errors
Runtime errors from Puppeteer are directly forwarded to the progress logger. This can be quickly confusing if there are errors. We should make it a bit more obvious via a consistent prefix.
1 parent aab4ee6 commit 520caca

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

runner/workers/serve-testing/puppeteer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ export async function runAppInPuppeteer(
4545
if (message.type() !== 'error') return;
4646

4747
if (!message.text().includes('JSHandle@error')) {
48-
progressLog('error', `${message.type().substring(0, 3).toUpperCase()} ${message.text()}`);
48+
progressLog(
49+
'error',
50+
`Runtime Error: ${message.type().substring(0, 3).toUpperCase()} ${message.text()}`,
51+
);
4952
return;
5053
}
5154
const messages = await Promise.all(

0 commit comments

Comments
 (0)