fix(overlay): incorrectly calculating using minWidth and minHeight as a string #18540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a string We use `minWidth` and `minHeight` to figure out whether an overlay can fit with its flexible dimensions. The problem is that the values can be either a string or a number, and if they're a string, the comparison breaks down because the value we're comparing it against is always a number. These changes also add a couple of extra tests for `minWidth` and `minHeight` since we didn't have any. Fixes angular#18486.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2020
… a string (#18540) We use `minWidth` and `minHeight` to figure out whether an overlay can fit with its flexible dimensions. The problem is that the values can be either a string or a number, and if they're a string, the comparison breaks down because the value we're comparing it against is always a number. These changes also add a couple of extra tests for `minWidth` and `minHeight` since we didn't have any. Fixes #18486. (cherry picked from commit 0d7e2f0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
minWidthandminHeightto figure out whether an overlay can fit with its flexible dimensions. The problem is that the values can be either a string or a number, and if they're a string, the comparison breaks down because the value we're comparing it against is always a number.These changes also add a couple of extra tests for
minWidthandminHeightsince we didn't have any.Fixes #18486.