fix: consistently use const enum #18390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
a team,
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
const-enum-usage
branch
3 times, most recently
from
b2776e5 to
3019a79
Compare
mmalerba
reviewed
Feb 4, 2020
jelbourn
approved these changes
Feb 5, 2020
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM aside from Miles' comment
Plain `enum` declarations generate a bunch of code that can't be minified very well and is included even if the enum isn't used. In most places we use `const enum` which inlines the value on consumption, but we have a few leftovers that are still using plain enums. These changes switch all of the remaining usages (except for one) and add a lint rule to enforce consistency in the future.
crisbeto
force-pushed
the
const-enum-usage
branch
from
3019a79 to
644f7be
Compare
devversion
approved these changes
Feb 5, 2020
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2020
Plain `enum` declarations generate a bunch of code that can't be minified very well and is included even if the enum isn't used. In most places we use `const enum` which inlines the value on consumption, but we have a few leftovers that are still using plain enums. These changes switch all of the remaining usages (except for one) and add a lint rule to enforce consistency in the future. (cherry picked from commit 8ae7b18)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain
enumdeclarations generate a bunch of code that can't be minified very well and is included even if the enum isn't used. In most places we useconst enumwhich inlines the value on consumption, but we have a few leftovers that are still using plain enums. These changes switch all of the remaining usages (except for one) and add a lint rule to enforce consistency in the future.Caretaker note: this has a small chance of being breaking if any of the enums are used in a view. I doubt that's the case, but we should re-evaluate if something breaks in g3.