fix(platform): RTL scrolling behavior detection not using cached value in some cases #18389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in some cases The `getRtlScrollAxisType` function caches its value so that we don't have to hit the DOM multiple times to detect the behavior. The problem is that when it reads the cached value, it does a simple falsy check which will also be true when we've resolved the value to `NORMAL`.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Feb 4, 2020
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2020
…e in some cases (#18389) The `getRtlScrollAxisType` function caches its value so that we don't have to hit the DOM multiple times to detect the behavior. The problem is that when it reads the cached value, it does a simple falsy check which will also be true when we've resolved the value to `NORMAL`. (cherry picked from commit 633e4c2)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getRtlScrollAxisTypefunction caches its value so that we don't have to hit the DOM multiple times to detect the behavior. The problem is that when it reads the cached value, it does a simple falsy check which will also be true when we've resolved the value toNORMAL(which is 0).