feat(schematics): add prompt to add global typography class #17602
+136
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a prompts to the `ng-add` schematic that allows the user to set the global `mat-typography` class on the `body`.
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Nov 4, 2019
| } | ||
|
|
||
| /** Adds the global typography class to the body element. */ | ||
| export function addTypographyClass(options: Schema): (host: Tree) => Tree { |
Member
Author
There was a problem hiding this comment.
Note: I can see this going into a separate file, but I kept it here because the typography system is tied to the theming.
devversion
approved these changes
Nov 4, 2019
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. I think it's fine to be part of theming.ts
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a prompts to the
ng-addschematic that allows the user to set the globalmat-typographyclass on thebody.Note: not totally sure whether we allow the schematic changes to be merge safe.