Skip to content

feat(material/slide-toggle/testing): polish harness API #17416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

feat(material/slide-toggle/testing): polish harness API #17416

merged 1 commit into from
Oct 16, 2019

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 15, 2019

  • Adds a name filter similar to the one on MatCheckboxHarness

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Oct 15, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 15, 2019
@mmalerba mmalerba requested a review from jelbourn October 15, 2019 22:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2019
jelbourn
jelbourn approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇵🇱

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 16, 2019
devversion
devversion approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit db999ff into angular:master Oct 16, 2019
@mmalerba mmalerba deleted the slide-toggle-harness-polish branch October 16, 2019 15:22
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 16, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @jelbourn @devversion @googlebot