fix(a11y): focus trap incorrectly moving focus internally if focus was already moved into it #18541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s already moved into it The new `ConfigurableFocusTrap` uses a timeout to allow for focus to be moved before it traps focus into itself, however if focus was moved into it before the timeout has fired, focus will be incorrectly moved to the first element in the trap. These changes add an extra check that ensures that focus isn't moved again if it's already inside the trap. Relates to angular#18538.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
approved these changes
Feb 18, 2020
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
ConfigurableFocusTrapuses a timeout to allow for focus to be moved before it traps focus into itself, however if focus was moved into it before the timeout has fired, focus will be incorrectly moved to the first element in the trap. These changes add an extra check that ensures that focus isn't moved again if it's already inside the trap.Relates to #18538.