fix(selection-list): incorrectly handling A key in some cases #18513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Feb 15, 2020
|
|
||
| spyOn(listOptions[2].componentInstance, 'focus').and.callThrough(); | ||
| listOptions[3].componentInstance._handleFocus(); | ||
| spyOn(listOptions[3].componentInstance, 'focus').and.callThrough(); |
Member
Author
There was a problem hiding this comment.
Some of these unrelated tests had to be tweaked, because I added an extra option to one of the fixtures.
jelbourn
reviewed
Feb 18, 2020
jelbourn
approved these changes
Feb 18, 2020
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, add merge-ready when ready
Fixes a couple of issues related to how the selection list handles the "A" key: 1. The typeahead doesn't work for the "A" key. It's because we were intercepting it earlier to support the "Select all" functionality. 2. Disables the ctrl + A shortcut in single selection mode, because it only makes sense during multi selection.
crisbeto
force-pushed
the
selection-list-a-key
branch
from
2b0998a to
3566209
Compare
devversion
approved these changes
Feb 18, 2020
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues related to how the selection list handles the "A" key: