Skip to content

feat(cdk/testing): add isFocused method to TestElement #18183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2020
Merged

feat(cdk/testing): add isFocused method to TestElement #18183

merged 2 commits into from
Jan 22, 2020

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jan 15, 2020

No description provided.

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Jan 15, 2020
@mmalerba mmalerba requested a review from jelbourn January 15, 2020 22:56
@mmalerba mmalerba requested a review from devversion as a code owner January 15, 2020 22:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 15, 2020
jelbourn
jelbourn approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the API gold updated

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 15, 2020
@ngbot
Copy link

ngbot bot commented Jan 15, 2020

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Jan 15, 2020
@mmalerba mmalerba force-pushed the test-element-is-focused branch from 937d710 to 172f3e1 Compare January 16, 2020 01:07
@mmalerba mmalerba requested a review from a team as a code owner January 16, 2020 01:07
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 16, 2020
@jelbourn jelbourn merged commit e704996 into angular:master Jan 22, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@mmalerba @yifange
feat(cdk/testing): add isFocused method to TestElement (angular#1…
2baff6e 
…8183)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 22, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @jelbourn @googlebot