fix(material-experimental/mdc-slide-toggle): fix extra border in latest canary version #18035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st canary version In the latest MDC Canary version an extra border was added to the slide toggle. The border also gets set to `transparent`, but due to insertion order gets overwritten by the base shorthand `border` declaration. This was only an issue for the `primary` color, because we were assuming that it's the default so we included less specific styles. These changes make it the same specificity as the other colors. Also bumps us to the latest MDC Canary version.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Dec 27, 2019
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest MDC Canary version an extra border was added to the slide toggle. The border also gets set to
transparent, but due to insertion order gets overwritten by the base shorthandborderdeclaration. This was only an issue for theprimarycolor, because we were assuming that it's the default so we included less specific styles. These changes make it the same specificity as the other colors.Also bumps us to the latest MDC Canary version.
For reference:
