fix(overlay): restore previous host element before attaching

[dirkluijk]

The first time when PositionStrategy.attach() is called, the overlay is already added to the DOM. However, after detaching and attaching again, it is not yet added to the DOM.

This PR changes the order and first restores the host element back, and then invokes the attach() method.

[jelbourn]

Is there a bug this is fixing? Are you able to add a unit test that captures the desired behavior?

[dirkluijk]

Yes, I am trying to calculate the size of the overlay in my own PositionStrategy. However, after detaching and attaching, the size is 0,0 because it is still outside the DOM.

I will add a unit test for that.

[dirkluijk]

I added the test. I double-checked it; without my fix it fails as expected.

[dirkluijk]

Pushed the requested change.

[crisbeto]

LGTM

[jelbourn]

LGTM

[dirkluijk]

Can this be merged?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}