fix(select): don't handle open key presses while the user is typing #17785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 25, 2019
We support typing into a select to skip to an item, as well as pressing space to open the select, however if the user is typing something that has a space in it, the select will open and interrupt the user. These changes add some logic so that we don't trigger the panel while the user is typing. Fixes angular#17774.
crisbeto
force-pushed
the
select-shortcut-while-typing
branch
from
5821492 to
4988d09
Compare
Member
Author
|
I've reworked it based on the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
devversion
reviewed
Nov 25, 2019
| it('should expose whether the user is currently typing', fakeAsync(() => { | ||
| expect(keyManager.isTyping()).toBe(false); | ||
|
|
||
| keyManager.onKeydown(createKeyboardEvent('keydown', 79, 'o')); // types "o" |
Member
There was a problem hiding this comment.
out of curiosity: why not using cdk/keycodes for the O keycode? (for consistency)
Member
There was a problem hiding this comment.
Nevermind.. I see other tests in this file hardcode the codes too.
Member
Author
There was a problem hiding this comment.
I think most of the tests in this file were written before we added as many constants to the CDK.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 27, 2019
…tion list Along the same lines as angular#17785. Doesn't handle space key presses while the user is using the typeahead so that we don't interrupt their typing.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 27, 2019
…tion list Along the same lines as angular#17785. Doesn't handle space key presses while the user is using the typeahead so that we don't interrupt their typing.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support typing into a select to skip to an item, as well as pressing space to open the select, however if the user is typing something that has a space in it, the select will open and interrupt the user. These changes add some logic so that we don't trigger the panel while the user is typing.
Fixes #17774.