feat(cdk/testing): support querying for multiple TestHarness / Compon… #17658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
andrewseguin,
crisbeto,
devversion and
jelbourn
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 9, 2019
crisbeto
reviewed
Nov 9, 2019
mmalerba
force-pushed
the
locator-for
branch
from
6c3c040 to
759893e
Compare
…entHarness at once in locatorFor
mmalerba
force-pushed
the
locator-for
branch
from
759893e to
28a6497
Compare
devversion
approved these changes
Nov 12, 2019
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. As a minor nit: It would be nice to mention that the skipSelectorCheck is only for performance purposes IMO.
Member
|
@mmalerba should this target 9.1? |
mmalerba
added
the
P2
Contributor
Author
|
I think we should try to get it in 9.0 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…entHarness at once in locatorFor
This feature is needed for the MatListHarness, so we can query for a combined list of list items, headers, and dividers, while maintaining the DOM order. The new API is a super-set of the old one, so non-breaking.