fix(popover-edit): incorrect spacing for form field inside popover

[crisbeto]

For some reason the padding on mat-form-field was reset inside the popover edit overlay which made it looked weird. From what I can tell, there's no reason to do this so these changes remove the override.

For reference, here's what it looks like at the moment:

[kseamon]

IIRC I did that to fix weird layout when there's no heading in the popup. Can you add a screenshot of that use case without the style override?

[crisbeto]

Updated the description with an "after" screenshot.

[kseamon]

Please also add a screenshot with one of the examples that does not have heading text. I think that’s the case that looked really bad with all the extra top padding in the form field.

Might be solvable with some negative margins?

[crisbeto]

Sure, here's a before and after. I don't think there's anything off about it:

[kseamon]

That’s it. The space reserved for the label causes a mismatch in vertical spacing above and below. Unfortunately the visual spec I’m working off of is internal or I’d share it.

Is there another less objectionable way to fix the spacing issue without overriding the form field styling?

[crisbeto]

How about only clearing the padding-top? The main issue I was aiming to address with this PR was the text being flush against the bottom border. Here's what removing the top padding only looks like:

[kseamon]

Looks good. Thanks.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}