Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 4, 2019

Since the cdkCopyToClipboard is a directive that uses an element selector, the name of the copied output needs to be namespaced. Since the API is already released, these changes deprecate the unprefixed version and add a prefixed one.

Since the `cdkCopyToClipboard` is a directive that uses an element selector, the name of the `copied` output needs to be namespaced. Since the API is already released, these changes deprecate the unprefixed version and add a prefixed one.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 4, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner November 4, 2019 09:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2019
@mmalerba mmalerba merged commit 1a2befa into angular:master Nov 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants