Skip to content

fix(list): selection list option not picking up indirect descendant lines #17514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

fix(list): selection list option not picking up indirect descendant lines #17514

merged 1 commit into from
Oct 30, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 26, 2019

Fixes mat-list-option not picking up mat-line instances that aren't direct descendants.

@crisbeto
fix(list): selection list option not picking up indirect descendant l…
d06c931 
…ines

Fixes `mat-list-option` not picking up `mat-line` instances that aren't direct descendants.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Oct 26, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Oct 26, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2019
jelbourn
jelbourn approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 28, 2019
@mmalerba mmalerba merged commit ee863b2 into angular:master Oct 30, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 30, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @jelbourn @devversion @googlebot @mmalerba