Skip to content

fix(button-toggle): indirect descendant buttons not picked up in some cases #17451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

fix(button-toggle): indirect descendant buttons not picked up in some cases #17451

merged 1 commit into from
Oct 21, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 19, 2019

Fixes button toggles that aren't direct descendants of the button group not being picked up in some cases.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Oct 19, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Oct 19, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner October 19, 2019 13:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2019
@crisbeto
fix(button-toggle): indirect descendant buttons not picked up in some…
cef0859 
… cases

Fixes button toggles that aren't direct descendants of the button group not being picked up in some cases.
@crisbeto crisbeto force-pushed the button-toggle-descendants branch from 99a1fca to cef0859 Compare October 19, 2019 13:35
jelbourn
jelbourn approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 21, 2019
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 21, 2019
@mmalerba mmalerba merged commit 67b009f into angular:master Oct 21, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 21, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba