Skip to content

feat: change tslib from direct dependency to peerDependency #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

feat: change tslib from direct dependency to peerDependency #17393

merged 1 commit into from
Oct 14, 2019

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 14, 2019

BREAKING CHANGE:

We no longer directly have a direct depedency on tslib. Instead it is now listed a peerDependency.

Users not using the CLI will need to manually install tslib via;

yarn add tslib

or

npm install tslib --save

Reference: TOOL-836

@alan-agius4
feat: change tslib from direct dependency to peerDependency
a598e99 
BREAKING CHANGE:

We no longer directly have a direct depedency on `tslib`. Instead it is now listed a `peerDependency`.

Users not using the CLI will need to manually install `tslib` via;
```
yarn add tslib
```
or
```
npm install tslib --save
```

Reference: TOOL-836
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 14, 2019
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Oct 14, 2019

Related also to: angular/angular#32167

@alan-agius4 alan-agius4 mentioned this pull request Oct 14, 2019
Closed
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Oct 14, 2019
jelbourn
jelbourn approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 14, 2019
@jelbourn jelbourn merged commit 41166b7 into angular:master Oct 14, 2019
@alan-agius4 alan-agius4 deleted the tslib-peerdeps branch October 14, 2019 17:39
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @jelbourn @googlebot