Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 10, 2019

Adds:

  • Ability to search for MatAutocompleteHarness based on value
  • Ability to filter getOptions with OptionHarnessFilters
  • Ability to filter getOptionGroups with OptionGroupHarnessFilters
  • Ability to select an option directly, without having to get the option harness

Removes:

  • MatAutocompleteHarness#getAttribute (prefer more focused APIs)
  • MatAutocompleteHarness#getPanel (want to avoid returning TestElement, prefer more focused APIs)
  • MatAutocompleteHarness#isPanelVisible (combined into isOpen)

Renames:

  • MatAutocompleteHarness#getText --> MatAutocompleteHarness#getValue
  • MatOptionGroupHarness#getLabelText --> MatOptionGroupHarness#getText

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release labels Oct 10, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 10, 2019
@mmalerba mmalerba requested review from crisbeto and jelbourn October 10, 2019 01:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2019
@mmalerba mmalerba force-pushed the autocomplete-harness-polish branch from d1a73e4 to 38ea57a Compare October 10, 2019 20:05
@mmalerba mmalerba force-pushed the autocomplete-harness-polish branch from 38ea57a to 473e75e Compare October 11, 2019 17:46
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from small nits, add merge-ready when ready

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 11, 2019
@mmalerba mmalerba force-pushed the autocomplete-harness-polish branch from 809a0ca to 0e50b9c Compare October 12, 2019 00:00
@mmalerba mmalerba force-pushed the autocomplete-harness-polish branch from 0e50b9c to c2b13de Compare October 12, 2019 21:53
@mmalerba mmalerba merged commit 7a748fc into angular:master Oct 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants