fix(snack-bar): handle large numbers passed in as duration #17239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles very large numbers being passed in as a snack bar duration (e.g. `Infinity`). We need to cap the duration, otherwise the browser will revert it back to 1 if it's too large. Fixes angular#17234.
crisbeto
added
P4
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 30, 2019
| } | ||
|
|
||
| /** Maximum amount of milliseconds that can be passed into setTimeout. */ | ||
| const MAX_TIMEOUT = Math.pow(2, 31) - 1; |
Member
There was a problem hiding this comment.
Why doesn't Number.MAX_SAFE_INTEGER work for this?
Member
Author
There was a problem hiding this comment.
AFAIK MAX_SAFE_INTEGER is 64bit, whereas setTimeout accepts 32bit.
jelbourn
approved these changes
Sep 30, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Another new terrible JavaScript fact
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles very large numbers being passed in as a snack bar duration (e.g.
Infinity). We need to cap the duration, otherwise the browser will revert it back to 1 if it's too large.Fixes #17234.