Skip to content

Commit 2a2d837

Browse files
devversionmmalerba
authored andcommitted
fix: google-maps and youtube-player package missing tslib dependency (#17939)
* build: use placeholder for tslib version * fix: google-maps and youtube-player package missing tslib dependency The google-maps and youtube-player package currently do not have `tslib` listed as dependency while TypeScript helper's are enabled and used in these packages.
1 parent 6ae74a0 commit 2a2d837

File tree

8 files changed

+12
-7
lines changed

8 files changed

+12
-7
lines changed

packages.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
# version for the placeholders.
44
ANGULAR_PACKAGE_VERSION = "^9.0.0-0 || ^10.0.0-0"
55
MDC_PACKAGE_VERSION = "^4.0.0"
6+
TSLIB_PACKAGE_VERSION = "^1.9.0"
7+
68
VERSION_PLACEHOLDER_REPLACEMENTS = {
79
"0.0.0-MDC": MDC_PACKAGE_VERSION,
810
"0.0.0-NG": ANGULAR_PACKAGE_VERSION,
11+
"0.0.0-TSLIB": TSLIB_PACKAGE_VERSION,
912
}
1013

1114
# List of default Angular library UMD bundles which are not processed by ngcc.

src/cdk-experimental/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"peerDependencies": {
2323
"@angular/cdk": "0.0.0-PLACEHOLDER",
2424
"@angular/core": "0.0.0-NG",
25-
"tslib": "^1.9.0"
25+
"tslib": "0.0.0-TSLIB"
2626
},
2727
"sideEffects": false,
2828
"publishConfig":{

src/cdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"peerDependencies": {
3030
"@angular/core": "0.0.0-NG",
3131
"@angular/common": "0.0.0-NG",
32-
"tslib": "^1.9.0"
32+
"tslib": "0.0.0-TSLIB"
3333
},
3434
"optionalDependencies": {
3535
"parse5": "^5.0.0"

src/google-maps/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
},
2626
"homepage": "https://github.com/angular/components/tree/master/src/google-maps#readme",
2727
"dependencies": {
28-
"@types/googlemaps": "^3.37.0"
28+
"@types/googlemaps": "^3.37.0",
29+
"tslib": "0.0.0-TSLIB"
2930
},
3031
"peerDependencies": {
3132
"@angular/core": "0.0.0-NG",

src/material-experimental/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@angular/core": "0.0.0-NG",
2424
"@angular/material": "0.0.0-PLACEHOLDER",
2525
"material-components-web": "0.0.0-MDC",
26-
"tslib": "^1.9.0"
26+
"tslib": "0.0.0-TSLIB"
2727
},
2828
"sideEffects": false,
2929
"publishConfig":{

src/material-moment-adapter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@angular/material": "0.0.0-PLACEHOLDER",
2424
"@angular/core": "0.0.0-NG",
2525
"moment": "^2.18.1",
26-
"tslib": "^1.9.0"
26+
"tslib": "0.0.0-TSLIB"
2727
},
2828
"ng-update": {
2929
"packageGroup": [

src/material/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"@angular/core": "0.0.0-NG",
3232
"@angular/common": "0.0.0-NG",
3333
"@angular/forms": "0.0.0-NG",
34-
"tslib": "^1.9.0"
34+
"tslib": "0.0.0-TSLIB"
3535
},
3636
"schematics": "./schematics/collection.json",
3737
"ng-update": {

src/youtube-player/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
},
2626
"homepage": "https://github.com/angular/components/tree/master/src/youtube-player#readme",
2727
"dependencies": {
28-
"@types/youtube": "^0.0.38"
28+
"@types/youtube": "^0.0.38",
29+
"tslib": "0.0.0-TSLIB"
2930
},
3031
"peerDependencies": {
3132
"@angular/core": "0.0.0-NG",

0 commit comments

Comments
 (0)