Skip to content

fix(afs): Better handle enablePersistence failures, esp. for Universal #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

fix(afs): Better handle enablePersistence failures, esp. for Universal #1850

merged 1 commit into from
Sep 4, 2018

Conversation

@jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

  • catchError wasn't cutting it, switching to try/catch
  • Don't try to enable persistence in Universal

Code sample

@jamesdaniels jamesdaniels requested a review from davideast August 31, 2018 21:41
davideast
davideast approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davideast davideast merged commit 334ba7b into master Sep 4, 2018
@jamesdaniels jamesdaniels mentioned this pull request Sep 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesdaniels @davideast @googlebot